Re: [PATCH 07/10] mci: add support for discarding write blocks

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Yann,

On 30.07.24 11:23, Yann Sionneau wrote:
> Hello Ahmad,

Thanks for the review. Can you please trim your replies in longer mails,
so it's easier to find the review?

> 
> Le 7/30/24 à 09:19, Ahmad Fatoum a écrit :
>> From: Ahmad Fatoum <ahmad@a3f.at>
>> +    while (i < blkcnt) {
>> +        sector_t blk_r;
>> +
>> +        /* TODO: While it's possible to clear many erase groups at once
>> +         * and it greatly improves throughput, drivers need adjustment:
>> +         *
>> +         * Many drivers hardcode a maximal wait time before aborting
>> +         * the wait for R1b and returning -ETIMEDOUT. With long
>> +         * erases/trims, we are bound to run into this timeout, so for now
>> +         * we just split into suifficiently small erases that are unlikely
> 
> suifficiently -> sufficiently

will fix.

> 
>> +         * to trigger the time.
> time -> timeout?

Yes.

Will fix for v2.

Thanks,
Ahmad

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |