From: Oleksij Rempel <linux@rempel-privat.de>
To: Du Huanpeng <u74147@gmail.com>, barebox@lists.infradead.org
Cc: Du Huanpeng <duhuanpeng@loongson.cn>
Subject: Re: [PATCH] MIPS: Makefile: minor codingstyle fix
Date: Fri, 22 Nov 2019 10:08:55 +0100 [thread overview]
Message-ID: <a3ba081f-5789-1f6c-cdba-e09a13561d7d@rempel-privat.de> (raw)
In-Reply-To: <1574411664-11733-1-git-send-email-duhuanpeng@loongson.cn>
Hi,
it is a bit more then just minor codingstyle fix. Can you please describe what was wrong and why the
change makes it better.
Am 22.11.19 um 09:34 schrieb Du Huanpeng:
> From: Du Huanpeng <u74147@gmail.com>
>
> Signed-off-by: Du Huanpeng <duhuanpeng@loongson.cn>
> ---
> arch/mips/Makefile | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/mips/Makefile b/arch/mips/Makefile
> index ee465dc..1c10db5 100644
> --- a/arch/mips/Makefile
> +++ b/arch/mips/Makefile
> @@ -52,9 +52,7 @@ cflags-$(CONFIG_CPU_MIPS32_R1) += $(call cc-option,-march=mips32,-mips32 -U_MIPS
> cflags-$(CONFIG_CPU_MIPS32_R2) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap
> cflags-$(CONFIG_CPU_MIPS64_R1) += $(call cc-option,-march=mips64,-mips64 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64 -Wa,--trap
> cflags-$(CONFIG_CPU_MIPS64_R2) += $(call cc-option,-march=mips64r2,-mips64r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64r2 -Wa,--trap
> -cflags-$(CONFIG_CPU_LOONGSON1) += \
> - $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) \
> - -Wa,-mips32r2 -Wa,--trap
> +cflags-$(CONFIG_CPU_LOONGSON1) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap
>
> CPPFLAGS += -DTEXT_BASE=$(CONFIG_TEXT_BASE)
>
>
--
Regards,
Oleksij
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-11-22 9:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 8:34 Du Huanpeng
2019-11-22 9:08 ` Oleksij Rempel [this message]
2019-11-22 9:46 ` Tim Williams
2019-11-22 11:11 ` Oleksij Rempel
2019-11-22 11:57 ` Du Huanpeng
2019-11-25 8:40 ` Sascha Hauer
2019-11-26 7:12 Du Huanpeng
2019-11-27 1:07 Du Huanpeng
2019-11-27 5:22 ` Oleksij Rempel
2019-11-27 5:58 ` Du Huanpeng
2019-11-27 14:02 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3ba081f-5789-1f6c-cdba-e09a13561d7d@rempel-privat.de \
--to=linux@rempel-privat.de \
--cc=barebox@lists.infradead.org \
--cc=duhuanpeng@loongson.cn \
--cc=u74147@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox