From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.gmx.net ([212.227.17.20]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iY4wE-0003fE-3X for barebox@lists.infradead.org; Fri, 22 Nov 2019 09:09:15 +0000 References: <1574411664-11733-1-git-send-email-duhuanpeng@loongson.cn> From: Oleksij Rempel Message-ID: Date: Fri, 22 Nov 2019 10:08:55 +0100 MIME-Version: 1.0 In-Reply-To: <1574411664-11733-1-git-send-email-duhuanpeng@loongson.cn> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] MIPS: Makefile: minor codingstyle fix To: Du Huanpeng , barebox@lists.infradead.org Cc: Du Huanpeng Hi, it is a bit more then just minor codingstyle fix. Can you please describe what was wrong and why the change makes it better. Am 22.11.19 um 09:34 schrieb Du Huanpeng: > From: Du Huanpeng > > Signed-off-by: Du Huanpeng > --- > arch/mips/Makefile | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/mips/Makefile b/arch/mips/Makefile > index ee465dc..1c10db5 100644 > --- a/arch/mips/Makefile > +++ b/arch/mips/Makefile > @@ -52,9 +52,7 @@ cflags-$(CONFIG_CPU_MIPS32_R1) += $(call cc-option,-march=mips32,-mips32 -U_MIPS > cflags-$(CONFIG_CPU_MIPS32_R2) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap > cflags-$(CONFIG_CPU_MIPS64_R1) += $(call cc-option,-march=mips64,-mips64 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64 -Wa,--trap > cflags-$(CONFIG_CPU_MIPS64_R2) += $(call cc-option,-march=mips64r2,-mips64r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS64) -Wa,-mips64r2 -Wa,--trap > -cflags-$(CONFIG_CPU_LOONGSON1) += \ > - $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) \ > - -Wa,-mips32r2 -Wa,--trap > +cflags-$(CONFIG_CPU_LOONGSON1) += $(call cc-option,-march=mips32r2,-mips32r2 -U_MIPS_ISA -D_MIPS_ISA=_MIPS_ISA_MIPS32) -Wa,-mips32r2 -Wa,--trap > > CPPFLAGS += -DTEXT_BASE=$(CONFIG_TEXT_BASE) > > -- Regards, Oleksij _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox