From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 14 Nov 2025 11:25:15 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vJqzT-000s7D-0N for lore@lore.pengutronix.de; Fri, 14 Nov 2025 11:25:15 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vJqzS-0004g2-Hq for lore@pengutronix.de; Fri, 14 Nov 2025 11:25:15 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vkcMaG8ae7L08hMw9Zdi9D+GWva4aoJ90pf9EUpAWWw=; b=fRay+Fyq2J0MLWeswPyPJt8wH8 ENu8MRKAjGGAMfelp9poR0lDOgJe++pi8WhkoNvw+fjPX7pXB7GF/RpeKBSpgc9rIWQeDJiCtbL+i W5f4GsZXm4fQKcUj+RXuokPRVUXLMHxHPU+VURioPL1h5mTHToIZ1ZqYub/Nx3U0MjC9xuN7ge7+A ceC+5KGtAduS7lJ6eYsqBy3n1Ymykd7PuaYYNaokN401bGTE7vwPKEjJGv5nGyZYQyL0+Si/zgQNe FTLgqfWOlr3+No0mY796BkFoQefFX/HHAT3i+xkikS6IkDbWlZRGgrsrt9WkOfzOdpX/iG4b4LBXf llU+C4eA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJqz0-0000000C0eH-10n6; Fri, 14 Nov 2025 10:24:46 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vJqyv-0000000C0cv-1Lwy for barebox@lists.infradead.org; Fri, 14 Nov 2025 10:24:44 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1vJqyr-0004aA-Kf; Fri, 14 Nov 2025 11:24:37 +0100 Message-ID: Date: Fri, 14 Nov 2025 11:24:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Ahmad Fatoum , Sascha Hauer , BAREBOX References: <20251112-tlv_bind_serial-v1-1-638cf222553a@pengutronix.de> From: Jonas Rebmann Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251114_022441_367256_733DC8FB X-CRM114-Status: GOOD ( 14.64 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] tlv: Add tlv_bind_serial mapping X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Hi Ahmad, On 2025-11-13 10:11, Ahmad Fatoum wrote: >> + struct bus_type *bus; >> + struct device_d *socdev; >> + const char *soc_serial; >> + char *tlv_serial = basprintf("%.*s", len, val); > > strndup would also work here. Since a such basprintf is used in __tlv_format_str() and tlv_format_blob(), I found it adequate to do it the same way. >> + >> + bus = get_bus_by_name("soc"); >> + if (!bus) { >> + pr_err("No 'soc' bus found\n"); > > goto out and use a common error message? That way you also cover the > case of no socdev existing. Ah indeed, will do that in v2. >> + return -EACCES; >> + } >> + >> + for_each_device(socdev) { >> + soc_serial = dev_get_param(socdev, "serial_number"); >> + if (!soc_serial) >> + continue; >> + >> + if (streq_ptr(tlv_serial, soc_serial)) >> + return __tlv_format_str(dev, map, len, val) ? 0 : -ENOMEM; > > return tlv_format_str(...) directly instead? > > I talked with Sascha yesterday and I believe he is implementing a common > get_soc_uid(). If so, that might be suitable for use here. Sounds good! When I wrote this code, I was unsure whether multiple SoC UIDs or a soc1.serial_number are cases we ever want to care about. If not, I would habe only tested against the one/first serial_number here and then break the loop... Will update to get_soc_uid() if that's posted before v2. Regards, Jonas -- Pengutronix e.K. | Jonas Rebmann | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |