Re: [PATCH 0/2] downgrade noisy debug calls in block devices and ramfs

[Stefan Kerkmann <s.kerkmann@pengutronix.de>]

Hi Ahmad,

On 28.10.24 17:44, Ahmad Fatoum wrote:
> Hi,
> 
> On 28.10.24 17:17, Stefan Kerkmann wrote:
>> These two patches are the outcome of an investigation why loading a
>> fitimage from an eMMC took nearly 7s - the sheer amount of generated
>> debugging messages slowed down the system by a factor of ~21 with
>> KConfig options:
>>
>> 	CONFIG_COMPILE_LOGLEVEL=7
>> 	CONFIG_DEFAULT_LOGLEVEL=6
>>
>> Which is the current default combination for barebox.
>>
>> Before:
>>
>> 	Booting entry 'system0'
>> 	FIT: Reading time: 6722 ms
>>
>> After:
>>
>> 	Booting entry 'system0'
>> 	FIT: Reading time: 324 ms
> 
> This is the time with these two patches applied or with
> compile log level changed?
> 

This is the time with both patches applied and the mentioned default log levels.

Cheers,
Stefan

> Cheers,
> Ahmad
> 
>>
>> Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
>> ---
>> Stefan Kerkmann (2):
>>       block: downgrade noisy debug calls to verbose debug
>>       fs: ramfs: downgrade noisy debug calls to verbose debug
>>
>>  common/block.c |  4 ++--
>>  fs/ramfs.c     | 10 +++++-----
>>  2 files changed, 7 insertions(+), 7 deletions(-)
>> ---
>> base-commit: 59658c877bcc605fe3ca36653b4f40f57856b81a
>> change-id: 20241028-fix-noisy-debug-calls-a6d6185be705
>>
>> Best regards,
> 
> 

-- 
Pengutronix e.K.                       | Stefan Kerkmann             |
Steuerwalder Str. 21                   | https://www.pengutronix.de/ |
31137 Hildesheim, Germany              | Phone: +49-5121-206917-128  |
Amtsgericht Hildesheim, HRA 2686       | Fax:   +49-5121-206917-9    |