mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Stefan Kerkmann <s.kerkmann@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	BAREBOX <barebox@lists.infradead.org>
Subject: Re: [PATCH 0/2] downgrade noisy debug calls in block devices and ramfs
Date: Mon, 28 Oct 2024 17:57:26 +0100	[thread overview]
Message-ID: <a8707ffc-be75-4943-9c67-bea50285fe12@pengutronix.de> (raw)
In-Reply-To: <d70eeeed-bb47-4d50-ac7e-5174c574aa33@pengutronix.de>

Hi Ahmad,

On 28.10.24 17:44, Ahmad Fatoum wrote:
> Hi,
> 
> On 28.10.24 17:17, Stefan Kerkmann wrote:
>> These two patches are the outcome of an investigation why loading a
>> fitimage from an eMMC took nearly 7s - the sheer amount of generated
>> debugging messages slowed down the system by a factor of ~21 with
>> KConfig options:
>>
>> 	CONFIG_COMPILE_LOGLEVEL=7
>> 	CONFIG_DEFAULT_LOGLEVEL=6
>>
>> Which is the current default combination for barebox.
>>
>> Before:
>>
>> 	Booting entry 'system0'
>> 	FIT: Reading time: 6722 ms
>>
>> After:
>>
>> 	Booting entry 'system0'
>> 	FIT: Reading time: 324 ms
> 
> This is the time with these two patches applied or with
> compile log level changed?
> 

This is the time with both patches applied and the mentioned default log levels.

Cheers,
Stefan

> Cheers,
> Ahmad
> 
>>
>> Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
>> ---
>> Stefan Kerkmann (2):
>>       block: downgrade noisy debug calls to verbose debug
>>       fs: ramfs: downgrade noisy debug calls to verbose debug
>>
>>  common/block.c |  4 ++--
>>  fs/ramfs.c     | 10 +++++-----
>>  2 files changed, 7 insertions(+), 7 deletions(-)
>> ---
>> base-commit: 59658c877bcc605fe3ca36653b4f40f57856b81a
>> change-id: 20241028-fix-noisy-debug-calls-a6d6185be705
>>
>> Best regards,
> 
> 

-- 
Pengutronix e.K.                       | Stefan Kerkmann             |
Steuerwalder Str. 21                   | https://www.pengutronix.de/ |
31137 Hildesheim, Germany              | Phone: +49-5121-206917-128  |
Amtsgericht Hildesheim, HRA 2686       | Fax:   +49-5121-206917-9    |




  reply	other threads:[~2024-10-28 16:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28 16:17 Stefan Kerkmann
2024-10-28 16:17 ` [PATCH 1/2] block: downgrade noisy debug calls to verbose debug Stefan Kerkmann
2024-10-28 16:17 ` [PATCH 2/2] fs: ramfs: " Stefan Kerkmann
2024-10-28 16:44 ` [PATCH 0/2] downgrade noisy debug calls in block devices and ramfs Ahmad Fatoum
2024-10-28 16:57   ` Stefan Kerkmann [this message]
2024-10-29 13:33 ` Sascha Hauer
2024-10-29 13:55   ` Ahmad Fatoum
2024-10-29 14:12   ` Stefan Kerkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8707ffc-be75-4943-9c67-bea50285fe12@pengutronix.de \
    --to=s.kerkmann@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox