Re: [PATCH v2 5/6] resource: supply memory type/attrs on all SDRAM requests

[Sascha Hauer <s.hauer@pengutronix.de>]

Hi Ahmad,

On Mon, May 26, 2025 at 04:19:13PM +0200, Ahmad Fatoum wrote:
>   * Request a region from the registered sdram
>   */
>  struct resource *__request_sdram_region(const char *name, unsigned flags,
> -					resource_size_t start, resource_size_t size)
> +				      resource_size_t start, resource_size_t size,
> +				      enum resource_memtype memtype, unsigned memattrs)
>  {
>  	struct memory_bank *bank;

This changes the prototype in the definition...

> diff --git a/include/memory.h b/include/memory.h
> index 707c0f13130d..7c5b133b7693 100644
> --- a/include/memory.h
> +++ b/include/memory.h
> @@ -33,14 +33,25 @@ int barebox_add_memory_bank(const char *name, resource_size_t start,
>  	if (((rsv)->flags & IORESOURCE_BUSY))
>  
>  struct resource *__request_sdram_region(const char *name, unsigned flags,
> -					resource_size_t start, resource_size_t size);
> +				      resource_size_t start, resource_size_t size);

...but not in the declaration causing intermediate compile errors.

Not sure what the correct fix is here. Could you fixup and send the
last two patches of this series again?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |