Re: [PATCH v2 5/6] ARM: mach-imx: tzasc: add imx6q_tzc380_is_enabled

[Sascha Hauer <s.hauer@pengutronix.de>]

On Thu, Jun 26, 2025 at 04:45:26PM +0200, Marco Felsch wrote:
> In preparation of adding an i.MX6QD optee-early helper add a helper to
> check if the early code e.g. PBL/BootROM enabled the TZC380 controllers
> on the i.MX6QDL.
> 
> Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> Changelog:
> v2:
> - Add Ahmad r-b
> 
>  arch/arm/mach-imx/tzasc.c | 15 +++++++++++++++
>  include/mach/imx/tzasc.h  |  1 +
>  2 files changed, 16 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/tzasc.c b/arch/arm/mach-imx/tzasc.c
> index 54f7d1d49715..b8270a4afdc8 100644
> --- a/arch/arm/mach-imx/tzasc.c
> +++ b/arch/arm/mach-imx/tzasc.c
> @@ -76,6 +76,9 @@
>  #define MX6_TZASC1_BASE			0x21d0000
>  #define MX6_TZASC2_BASE			0x21d4000
>  
> +#define MX6_GPR_TZASC1_EN		BIT(0)
> +#define MX6_GPR_TZASC2_EN		BIT(1)
> +
>  #define GPR_TZASC_EN					BIT(0)
>  #define GPR_TZASC_ID_SWAP_BYPASS		BIT(1)
>  #define GPR_TZASC_EN_LOCK				BIT(16)
> @@ -294,6 +297,18 @@ void imx6q_tzc380_early_ns_region1(void)
>  				  TZC380_REGION_SP_NS_RW);
>  }
>  
> +bool imx6q_tzc380_is_enabled(void)

I think the function name is misleading. The function does not return
the tzc380 enabled status, but whether SDRAM accesses are checked or
bypassed.

When bypassed you can still enable the tzc380, but SDRAM accesses are
not checked anymore.

imx6q_tzc380_is_bypassed() would be a better name.

I am currently working on a unified series which includes this series
with i.MX6UL support added and my fix-chainload series, so no need to
resend now.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |