From: Sascha Hauer <s.hauer@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH] fixup! test: Add pytest suite for NVMEM framework
Date: Tue, 24 Jun 2025 12:29:46 +0200 [thread overview]
Message-ID: <aFp-GsP5VXbjhb6B@pengutronix.de> (raw)
In-Reply-To: <aFpiFmyiNN6IL5UI@pengutronix.de>
On Tue, Jun 24, 2025 at 10:30:14AM +0200, Oleksij Rempel wrote:
> On Tue, Jun 24, 2025 at 10:17:12AM +0200, Ahmad Fatoum wrote:
> > If CONFIG_DEBUG_PROBES is enabled, barebox will print an info log
> > whenever a device is probed. This breaks one test case in the newly
> > introduced nvmem tests, because running the nvmem command results in two
> > lines instead of one:
> >
> > probe-> rmem1
> > rmem1
> >
> > A better solution might be disabling stderr, but for now, let's just
> > have the test check all lines that appeared after running the command.
> >
> > This fixes CI breakage in next.
> >
> > Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>
> LGTM
>
> May be better to keep it as separate patch, not as fixup? Since It provides
> important information.
I agree it provides important information, I just don't see how one
would find it when he needs it, so I decided to keep this as a fixup.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-06-24 11:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 8:17 Ahmad Fatoum
2025-06-24 8:30 ` Oleksij Rempel
2025-06-24 8:59 ` Ahmad Fatoum
2025-06-24 10:29 ` Sascha Hauer [this message]
2025-06-24 10:28 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFp-GsP5VXbjhb6B@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox