mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Stafford Horne <shorne@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH] openrisc: fix include file protection
Date: Wed, 3 Sep 2025 14:23:35 +0100	[thread overview]
Message-ID: <aLhBVzl4cgK6thGN@antec> (raw)
In-Reply-To: <20250903120228.3485457-1-s.hauer@pengutronix.de>

On Wed, Sep 03, 2025 at 02:02:28PM +0200, Sascha Hauer wrote:
> Fixes:
> 
> arch/openrisc/include/asm/common.h:3: error: header guard '_ASM_COMMON_H' followed by '#define' of a different macro [-Werror=header-guard]
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Thats a good check to have.

Reviewed-by: Stafford Horne <shorne@gmail.com>

> ---
>  arch/openrisc/include/asm/common.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/openrisc/include/asm/common.h b/arch/openrisc/include/asm/common.h
> index 06bb4824a2..320037de32 100644
> --- a/arch/openrisc/include/asm/common.h
> +++ b/arch/openrisc/include/asm/common.h
> @@ -1,6 +1,6 @@
>  /* SPDX-License-Identifier: GPL-2.0-only */
>  
> -#ifndef _ASM_COMMON_H
> +#ifndef __ASM_COMMON_H
>  #define __ASM_COMMON_H
>  
> -#endif /* _ASM_COMMON_H */
> +#endif /* __ASM_COMMON_H */
> -- 
> 2.47.2
> 
> 



  reply	other threads:[~2025-09-03 17:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03 12:02 Sascha Hauer
2025-09-03 13:23 ` Stafford Horne [this message]
2025-09-03 13:30 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLhBVzl4cgK6thGN@antec \
    --to=shorne@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox