* [PATCH] openrisc: fix include file protection
@ 2025-09-03 12:02 Sascha Hauer
2025-09-03 13:23 ` Stafford Horne
2025-09-03 13:30 ` Sascha Hauer
0 siblings, 2 replies; 3+ messages in thread
From: Sascha Hauer @ 2025-09-03 12:02 UTC (permalink / raw)
To: Barebox List
Fixes:
arch/openrisc/include/asm/common.h:3: error: header guard '_ASM_COMMON_H' followed by '#define' of a different macro [-Werror=header-guard]
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
arch/openrisc/include/asm/common.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/openrisc/include/asm/common.h b/arch/openrisc/include/asm/common.h
index 06bb4824a2..320037de32 100644
--- a/arch/openrisc/include/asm/common.h
+++ b/arch/openrisc/include/asm/common.h
@@ -1,6 +1,6 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-#ifndef _ASM_COMMON_H
+#ifndef __ASM_COMMON_H
#define __ASM_COMMON_H
-#endif /* _ASM_COMMON_H */
+#endif /* __ASM_COMMON_H */
--
2.47.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] openrisc: fix include file protection
2025-09-03 12:02 [PATCH] openrisc: fix include file protection Sascha Hauer
@ 2025-09-03 13:23 ` Stafford Horne
2025-09-03 13:30 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Stafford Horne @ 2025-09-03 13:23 UTC (permalink / raw)
To: Sascha Hauer; +Cc: Barebox List
On Wed, Sep 03, 2025 at 02:02:28PM +0200, Sascha Hauer wrote:
> Fixes:
>
> arch/openrisc/include/asm/common.h:3: error: header guard '_ASM_COMMON_H' followed by '#define' of a different macro [-Werror=header-guard]
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Thats a good check to have.
Reviewed-by: Stafford Horne <shorne@gmail.com>
> ---
> arch/openrisc/include/asm/common.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/openrisc/include/asm/common.h b/arch/openrisc/include/asm/common.h
> index 06bb4824a2..320037de32 100644
> --- a/arch/openrisc/include/asm/common.h
> +++ b/arch/openrisc/include/asm/common.h
> @@ -1,6 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0-only */
>
> -#ifndef _ASM_COMMON_H
> +#ifndef __ASM_COMMON_H
> #define __ASM_COMMON_H
>
> -#endif /* _ASM_COMMON_H */
> +#endif /* __ASM_COMMON_H */
> --
> 2.47.2
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] openrisc: fix include file protection
2025-09-03 12:02 [PATCH] openrisc: fix include file protection Sascha Hauer
2025-09-03 13:23 ` Stafford Horne
@ 2025-09-03 13:30 ` Sascha Hauer
1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2025-09-03 13:30 UTC (permalink / raw)
To: Barebox List, Sascha Hauer
On Wed, 03 Sep 2025 14:02:28 +0200, Sascha Hauer wrote:
> Fixes:
>
> arch/openrisc/include/asm/common.h:3: error: header guard '_ASM_COMMON_H' followed by '#define' of a different macro [-Werror=header-guard]
>
>
Applied, thanks!
[1/1] openrisc: fix include file protection
https://git.pengutronix.de/cgit/barebox/commit/?id=239e6faaa18b (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-03 17:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-03 12:02 [PATCH] openrisc: fix include file protection Sascha Hauer
2025-09-03 13:23 ` Stafford Horne
2025-09-03 13:30 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox