From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@barebox.org>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] test: py: add dry run check for FIT image
Date: Mon, 19 Jan 2026 12:26:27 +0100 [thread overview]
Message-ID: <aW4U4_oW-TftHzGa@pengutronix.de> (raw)
In-Reply-To: <20260116101404.3954872-1-a.fatoum@barebox.org>
On Fri, Jan 16, 2026 at 11:14:03AM +0100, Ahmad Fatoum wrote:
> A dry run should not alter system state in a way that would inhibit
> normal operation or repeated dry runs.
>
> The FIT image boot in the test suite, however, reduces the VFS root's
> reference count beyond the initial value before the bootm.
>
> This leads to a warning on boot that can be reproduced by repeating the
> dry run multiple times:
>
> FAILED test/py/test_fit.py::test_fit_dryrun -
> AssertionError: ['WARNING: at fs/fs.c:255/mntput()!',
> 'WARNING: refcount for mount "/" becomes negative']
>
> Add a regression test for this issue.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@barebox.org>
> ---
> @Sascha, given that you introduced the warning, maybe you are interested
> in looking into this? :-)
> I am not sure if it's 9PFS related. It's reproducible with:
No, it's not 9pfs related. It's the O_TMPFILE creation that bites us
here. I've sent a fix.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2026-01-19 11:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 10:14 Ahmad Fatoum
2026-01-19 11:26 ` Sascha Hauer [this message]
2026-01-19 11:42 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW4U4_oW-TftHzGa@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@barebox.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox