From: Sascha Hauer <s.hauer@pengutronix.de>
To: Sohaib Mohamed <sohaib.amhmd@gmail.com>
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>,
BAREBOX <barebox@lists.infradead.org>
Subject: Re: [PATCH 06/14] ARM: rockchip: Add RK3562 KickPi K3 board support
Date: Fri, 23 Jan 2026 10:46:12 +0100 [thread overview]
Message-ID: <aXNDZFjT0rABB7G3@pengutronix.de> (raw)
In-Reply-To: <20260116-barebox-kickpi-v1-6-d11fbccd527a@gmail.com>
On Fri, Jan 16, 2026 at 08:40:40PM +0100, Sohaib Mohamed wrote:
> KICKPI-K3 is a development board based on Rockchip RK3562, the main
> control chip. It has a quad-core 64-bit Cortex-A53 processor, a main
> frequency of up to 2.0GHz, low power consumption, and high performance.
>
> Signed-off-by: Sohaib Mohamed <sohaib.amhmd@gmail.com>
> ---
> arch/arm/boards/Makefile | 1 +
> .../boards/rockchip-rk3562-kickpi-k3/.gitignore | 1 +
> arch/arm/boards/rockchip-rk3562-kickpi-k3/Makefile | 4 ++
> arch/arm/boards/rockchip-rk3562-kickpi-k3/board.c | 46 ++++++++++++++++++++++
> .../boards/rockchip-rk3562-kickpi-k3/lowlevel.c | 23 +++++++++++
> arch/arm/configs/multi_v8_defconfig | 1 +
> arch/arm/configs/rockchip_v8_defconfig | 1 +
> arch/arm/dts/Makefile | 1 +
> arch/arm/dts/rk3562-kickpi-k3.dts | 10 +++++
> arch/arm/dts/rk3562-kickpi-k3.dtsi | 2 +-
> arch/arm/mach-rockchip/Kconfig | 6 +++
> images/Makefile.rockchip | 1 +
> 12 files changed, 96 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boards/Makefile b/arch/arm/boards/Makefile
> index 946af95560..2a8e85e0b3 100644
> --- a/arch/arm/boards/Makefile
> +++ b/arch/arm/boards/Makefile
> @@ -186,6 +186,7 @@ obj-$(CONFIG_MACH_LS1021AIOT) += ls1021aiot/
> obj-$(CONFIG_MACH_MNT_REFORM) += mnt-reform/
> obj-$(CONFIG_MACH_SKOV_ARM9CPU) += skov-arm9cpu/
> obj-$(CONFIG_MACH_RK3562_EVB2) += rockchip-rk3562-evb2/
> +obj-$(CONFIG_MACH_RK3562_KICKPI_K3) += rockchip-rk3562-kickpi-k3/
> obj-$(CONFIG_MACH_RK3568_EVB) += rockchip-rk3568-evb/
> obj-$(CONFIG_MACH_RK3568_BPI_R2PRO) += rockchip-rk3568-bpi-r2pro/
> obj-$(CONFIG_MACH_PINE64_PINETAB2) += pine64-pinetab2/
> diff --git a/arch/arm/boards/rockchip-rk3562-kickpi-k3/.gitignore b/arch/arm/boards/rockchip-rk3562-kickpi-k3/.gitignore
> new file mode 100644
> index 0000000000..f458f794b5
> --- /dev/null
> +++ b/arch/arm/boards/rockchip-rk3562-kickpi-k3/.gitignore
> @@ -0,0 +1 @@
> +sdram-init.bin
> diff --git a/arch/arm/boards/rockchip-rk3562-kickpi-k3/Makefile b/arch/arm/boards/rockchip-rk3562-kickpi-k3/Makefile
> new file mode 100644
> index 0000000000..da63d2625f
> --- /dev/null
> +++ b/arch/arm/boards/rockchip-rk3562-kickpi-k3/Makefile
> @@ -0,0 +1,4 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +obj-y += board.o
> +lwl-y += lowlevel.o
> diff --git a/arch/arm/boards/rockchip-rk3562-kickpi-k3/board.c b/arch/arm/boards/rockchip-rk3562-kickpi-k3/board.c
> new file mode 100644
> index 0000000000..9e96bafb88
> --- /dev/null
> +++ b/arch/arm/boards/rockchip-rk3562-kickpi-k3/board.c
> @@ -0,0 +1,46 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +
> +#define pr_fmt(fmt) "rk3562-kickpi-k3: " fmt
> +
> +#include <bootsource.h>
> +#include <common.h>
> +#include <init.h>
> +#include <mach/rockchip/bbu.h>
> +#include <globalvar.h>
> +#include <deep-probe.h>
Clean up a bit globalvar.h and deep-probe.h are not yet needed.
> diff --git a/arch/arm/dts/rk3562-kickpi-k3.dtsi b/arch/arm/dts/rk3562-kickpi-k3.dtsi
> index 77bd61cf30..ad5349d7c4 100644
> --- a/arch/arm/dts/rk3562-kickpi-k3.dtsi
> +++ b/arch/arm/dts/rk3562-kickpi-k3.dtsi
> @@ -22,7 +22,7 @@ aliases {
> };
>
> chosen {
> - stdout-path = "console=serial0,1500000n8";
> + stdout-path = "serial0:1500000n8";
> };
This was just introduced in a previous patch. Please squash this hunk in
there.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2026-01-23 9:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-16 19:40 [PATCH 00/14] Initial support for Rockchip RK3562 Sohaib Mohamed
2026-01-16 19:40 ` [PATCH 01/14] ARM: rockchip: Add initial RK3562 SoC support Sohaib Mohamed
2026-01-16 19:40 ` [PATCH 02/14] clk: rockchip: add RK3562 clock and reset driver support Sohaib Mohamed
2026-01-16 19:40 ` [PATCH 03/14] pinctrl: rockchip: sync driver with Linux Sohaib Mohamed
2026-01-16 19:40 ` [PATCH 04/14] ARM: boards: Rockchip: add RK3562-EVB2 support Sohaib Mohamed
2026-01-16 19:40 ` [PATCH 05/14] ARM: boards: Rockchip: Add device tree for kickpi k3 board Sohaib Mohamed
2026-01-16 19:40 ` [PATCH 06/14] ARM: rockchip: Add RK3562 KickPi K3 board support Sohaib Mohamed
2026-01-23 9:46 ` Sascha Hauer [this message]
2026-01-16 19:40 ` [PATCH 07/14] pmdomain: rockchip: Add RK3562 power domain support Sohaib Mohamed
2026-01-16 19:40 ` [PATCH 08/14] aiodev: rockchip_saradc: Add RK3562 support Sohaib Mohamed
2026-01-16 19:40 ` [PATCH 09/14] phy: rockchip-inno-usb2: Add support for RK3562 PHY Sohaib Mohamed
2026-01-16 19:40 ` [PATCH 10/14] rockchip-rng: Add RK3562 support Sohaib Mohamed
2026-01-16 19:40 ` [PATCH 11/14] mci: sdhci: rockchip-dwcmshc: " Sohaib Mohamed
2026-01-16 19:40 ` [PATCH 12/14] nvmem: rockchip-otp: " Sohaib Mohamed
2026-01-16 19:40 ` [PATCH 13/14] phy: rockchip: inno-dsidphy: " Sohaib Mohamed
2026-01-16 19:40 ` [PATCH 14/14] phy: rockchip: naneng-combphy: " Sohaib Mohamed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXNDZFjT0rABB7G3@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sohaib.amhmd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox