mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Renaud Barbier <renaud.barbier@ametek.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 4/4] ARM: ls1021a: initial Ethernet and mdio configuration
Date: Mon, 9 Feb 2026 15:43:59 +0100	[thread overview]
Message-ID: <aYnyr03HdE8B-b5o@pengutronix.de> (raw)
In-Reply-To: <20260204114621.2130261-5-renaud.barbier@ametek.com>

Hi Renaud,

On Wed, Feb 04, 2026 at 11:46:21AM +0000, Renaud Barbier wrote:
> diff --git a/arch/arm/dts/fsl-ls1021a-iot.dts b/arch/arm/dts/fsl-ls1021a-iot.dts
> index d7e8bcc7ed..33282c8f52 100644
> --- a/arch/arm/dts/fsl-ls1021a-iot.dts
> +++ b/arch/arm/dts/fsl-ls1021a-iot.dts
> @@ -69,6 +69,34 @@ &i2c2 {
>  	status = "disabled";
>  };
>  
> +&enet0 {
> +	status = "disabled";
> +};
> +
> +&enet1 {
> +	tbi-handle = <&tbi1>;
> +	phy-handle = <&phy3>;
> +	phy-mode = "sgmii";
> +	/* Disable property as transmit fails without a DMA sync */
> +	/delete-property/ dma-coherent;
> +};
> +
> +&enet2 {
> +	status = "disabled";
> +};
> +
> +&mdio0 {
> +	/* Rename the compatible name property as the mdio register offset
> +	 * in the gianfar driver depends on this name. Once the driver
> +	 * is in sync with Linux, it may be gone.
> +	 */
> +	compatible = "fsl,etsec2-mdio";

What am I missing here? The "fsl,etsec2-mdio" compatible is introduced
in your patch series and the original "gianfar" compatible is unused in
barebox, so why not use the original "gianfar" compatible?

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  reply	other threads:[~2026-02-09 14:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 11:46 [PATCH v2 0/4] net: expand gianfar support to ls1021a Renaud Barbier
2026-02-04 11:46 ` [PATCH v2 1/4] net: gianfar: disable link information Renaud Barbier
2026-02-04 11:46 ` [PATCH v2 2/4] gianfar: apply checkpatch recommendations Renaud Barbier
2026-02-04 11:46 ` [PATCH v2 3/4] net:gianfar: add device tree support Renaud Barbier
2026-02-04 11:46 ` [PATCH v2 4/4] ARM: ls1021a: initial Ethernet and mdio configuration Renaud Barbier
2026-02-09 14:43   ` Sascha Hauer [this message]
2026-02-09 17:46     ` Renaud Barbier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYnyr03HdE8B-b5o@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=renaud.barbier@ametek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox