Re: [PATCH master] mci: dw_mmc: drop CD from mask programmed into interrupt status register

[Sascha Hauer <s.hauer@pengutronix.de>]

On Mon, Feb 23, 2026 at 12:40:33PM +0100, Ahmad Fatoum wrote:
> Hello Sascha,
> 
> On 2/23/26 12:37 PM, Sascha Hauer wrote:
> > On Mon, Feb 09, 2026 at 05:40:44PM +0100, Ahmad Fatoum wrote:
> >> We don't usually care for the card detect in barebox and just
> >> unconditionally try to access the card. If it fails, a probe can be
> >> attempted later via setting mmcX.probe=1.
> >>
> >> The dw_mmc driver diverges from this and enables all kinds
> >> of interrupts in the interrupt status polled after submitting commands,
> >> including card-detect.
> >>
> >> This appears to be problematic, when we have a GPIO card detect and are
> >> not using the card detect hardware function.
> >>
> >> Align behavior with Linux and skip polling for hardware card-detect when
> >> we have a GPIO card detect. The current behavior was inherited from
> >> U-Boot, which still does it this way and it's possible it would be affected
> >> by this issue as well, once U-Boot updates to use DTs >= v6.19-rc1, provided
> >> that the ROCK 5 support in U-Boot uses CONFIG_OF_UPSTREAM.
> >>
> >> Fixes: a3bf6c16f77d ("dts: update to v6.19-rc1")
> >> Reported-by: Michael Tretter <m.tretter@pengutronix.de>
> >> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> >> ---
> >>  drivers/mci/dw_mmc.c | 33 ++++++++++++++++++++++++++++++++-
> >>  drivers/mci/dw_mmc.h |  1 +
> >>  2 files changed, 33 insertions(+), 1 deletion(-)
> > 
> > Given that this doesn't resolve Michaels issue I won't apply it for
> > master. Anyway, the patch might still be correct, so what should I do
> > with it?
> 
> Let's leave it unapplied for now until the reported issue is fixed (I
> heard you have access to the HW in question, so I am hopful :-).

Indeed :)

> 
> Once the original issue is fixed, this can be applied of top if it was
> not found to be breaking anything.

Ok.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |