From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 23 Feb 2026 12:51:15 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vuUT4-004ov5-0J for lore@lore.pengutronix.de; Mon, 23 Feb 2026 12:51:14 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vuUT4-0001jG-DM for lore@pengutronix.de; Mon, 23 Feb 2026 12:51:14 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r2ZbikIYDL1ImocBC5sPKYAfCxfW8sILaLp/mKM9aYE=; b=eSybZ7vSopCF9lSsYF/K7mWpLN fSty3l53A65gO17LNS3enwq0iCXW6uZqD1yvS4+J6tkCWzLwr0P4hkQC8OV+57uhOGWtHHoQJD/BP dGUEGk1cHSR8cx/VsgDF1RigIjHHLKeArTxx6H/gdcG47ahbc+QW8w6/0LgM2jHJIPCrW7kwlkN34 uvz/Q7VOscF8D+bZ3MgcVIXU7AMmXLaL3ZbyQKOalGvCywAGj9Z4bnHWfpf/V94wuihjaY9mFpHtL SF2fO7L4qEo64ZecJRXCueBb55PmVgIJy3QG3HYbsnHV0uGDyLbuu4JJsR3cwF/PtcXSHbqoeyz8B NzuOfS4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vuUSc-00000000DdX-0tL3; Mon, 23 Feb 2026 11:50:46 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vuUSZ-00000000DdC-1PQh for barebox@lists.infradead.org; Mon, 23 Feb 2026 11:50:45 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vuUSX-0001da-Kd; Mon, 23 Feb 2026 12:50:41 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vuUSW-002Dsr-0K; Mon, 23 Feb 2026 12:50:41 +0100 Received: from sha by pty.whiteo.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1vuUSX-000000017sx-1UlB; Mon, 23 Feb 2026 12:50:41 +0100 Date: Mon, 23 Feb 2026 12:50:41 +0100 From: Sascha Hauer To: Ahmad Fatoum Cc: barebox@lists.infradead.org, "Claude Opus 4.6" Message-ID: References: <20260223113446.638135-1-a.fatoum@barebox.org> <20260223113446.638135-4-a.fatoum@barebox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260223113446.638135-4-a.fatoum@barebox.org> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260223_035044_032931_17692320 X-CRM114-Status: GOOD ( 21.53 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 3/4] MAKEALL: error out on options placed after the defconfig argument X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On Mon, Feb 23, 2026 at 12:31:34PM +0100, Ahmad Fatoum wrote: > getopts stops parsing at the first non-option argument, so options > like -k after the defconfig name silently end up as positional > arguments. For bare defconfigs these get misinterpreted as pytest > options and are silently ignored, leading to a build without the > intended configuration. > > Detect this by checking for trailing arguments when any positional > argument is a bare defconfig (not a labgrid .yaml config, where > extra arguments are intentionally forwarded to pytest). Can't we use getopt for MAKEALL instead of getopts? getopt just does the right thing. Sascha > > Co-Authored-By: Claude Opus 4.6 > Signed-off-by: Ahmad Fatoum > --- > MAKEALL | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/MAKEALL b/MAKEALL > index c36aed625820..dd0b7f8003cc 100755 > --- a/MAKEALL > +++ b/MAKEALL > @@ -440,6 +440,15 @@ else > > configs+=($i) > done > + if [ ${#pytest_opts[@]} -gt 0 ]; then > + for i in "${configs[@]}"; do > + if ! [[ $i =~ .yaml$ ]]; then > + echo "error: unexpected arguments after defconfig: ${pytest_opts[*]}" >&2 > + echo "hint: place all options before the defconfig argument" >&2 > + exit 1 > + fi > + done > + fi > for i in "${configs[@]}"; do > config=$i > if [[ $i =~ ^.*/([^/]+)/([^@]*@|)([^.]+).yaml$ ]]; then > -- > 2.47.3 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |