mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Denis Orlov <denorl2009@gmail.com>
To: Ian Abbott <abbotti@mev.co.uk>, barebox@lists.infradead.org
Subject: Re: [PATCH] nios2: remove arch remains from drivers
Date: Fri, 30 Jun 2023 21:55:29 +0300	[thread overview]
Message-ID: <ab0ad661-511e-5f56-2086-f3be2a1ff6ae@gmail.com> (raw)
In-Reply-To: <2174e39f-3e29-bd33-ab15-ba0eb86a58f5@mev.co.uk>

On 6/30/23 11:57, Ian Abbott wrote:
> On 29/06/2023 21:13, Denis Orlov wrote:
>> The architecture was removed back in the commit efccc13513, however some
>> drivers that were available exclusively for NIOS2 were left over. As it
>> has been impossible to compile those since then, it seems reasonable to
>> just get rid of them.
>>
>> Signed-off-by: Denis Orlov <denorl2009@gmail.com>
>> ---
>>   drivers/serial/Kconfig              |  10 --
>>   drivers/serial/Makefile             |   2 -
>>   drivers/serial/serial_altera.c      |  94 -----------
>>   drivers/serial/serial_altera_jtag.c |  99 ------------
>>   drivers/spi/Kconfig                 |   4 -
>>   drivers/spi/Makefile                |   1 -
>>   drivers/spi/altera_spi.c            | 236 ----------------------------
>>   7 files changed, 446 deletions(-)
>>   delete mode 100644 drivers/serial/serial_altera.c
>>   delete mode 100644 drivers/serial/serial_altera_jtag.c
>>   delete mode 100644 drivers/spi/altera_spi.c
>
> As a point of interest, none of those drivers should really depend on NIOS2.  They are usable on an ARM SoCFPGA system if the FPGA logic contains the corresponding Altera/Intel IP components.
>
> Whether or not anyone needs them in barebox is another matter, but I have certainly used them in ARM SoCFPGA Linux systems booted from barebox.
>

Hmm, maybe those drivers should rather depend on ARCH_SOCFPGA then? Would be great if someone tested them in barebox running on a SoCFPGA. Otherwise, they are just rotting in the source tree, with no actual usage.

Regards,
Denis




  reply	other threads:[~2023-06-30 18:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29 20:13 Denis Orlov
2023-06-30  8:57 ` Ian Abbott
2023-06-30 18:55   ` Denis Orlov [this message]
2023-07-03  8:43     ` Sascha Hauer
2023-07-03 13:21 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab0ad661-511e-5f56-2086-f3be2a1ff6ae@gmail.com \
    --to=denorl2009@gmail.com \
    --cc=abbotti@mev.co.uk \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox