From: "Daniel Glöckner" <dg@emlix.com>
To: Sascha Hauer <s.hauer@pengutronix.de>,
Barebox List <barebox@lists.infradead.org>
Cc: Edmund Henniges <eh@emlix.com>
Subject: Re: [PATCH 03/11] Introduce slices
Date: Fri, 8 May 2020 20:01:00 +0200 [thread overview]
Message-ID: <aca473b4-a4ef-1c8e-958f-dcec8044049d@emlix.com> (raw)
In-Reply-To: <20200422075452.25226-4-s.hauer@pengutronix.de>
Hello Sascha,
Am 22.04.20 um 09:54 schrieb Sascha Hauer:
> diff --git a/commands/Kconfig b/commands/Kconfig
> index 7fb47b8fb5..5ff6454427 100644
> --- a/commands/Kconfig
> +++ b/commands/Kconfig
> @@ -269,6 +269,15 @@ config CMD_POLLER
> is_timeout() or one of the various delay functions. The poller command prints
> informations about registered pollers.
>
> +config CMD_SLICE
> + tristate
> + prompt "slice"
> + depends on SLICE
> + help
> + slices are a way to protect resources from being accessed by pollers. The slice
> + command can be used to print informations about slices and also to manipulate
> + them on the command line for debugging purposes.
> +
> # end Information commands
> endmenu
>
> diff --git a/common/Kconfig b/common/Kconfig
> index 400c0553cf..bd2aebac75 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -913,6 +913,10 @@ config BAREBOXCRC32_TARGET
> config POLLER
> bool "generic polling infrastructure"
>
> +config SLICE
> + depends on POLLER
> + default y
> +
> config STATE
> bool "generic state infrastructure"
> select CRC32
> diff --git a/common/Makefile b/common/Makefile
> index 84463b4d48..16f14db41c 100644
> --- a/common/Makefile
> +++ b/common/Makefile
> @@ -11,6 +11,7 @@ obj-y += bootsource.o
> obj-$(CONFIG_ELF) += elf.o
> obj-y += restart.o
> obj-y += poweroff.o
> +obj-y += slice.o
> obj-$(CONFIG_MACHINE_ID) += machine_id.o
> obj-$(CONFIG_AUTO_COMPLETE) += complete.o
> obj-y += version.o
the Kconfig logic doesn't make sense to me. slice.o gets built regardless of
CONFIG_SLICE and it will still compile and link when CONFIG_POLLER is disabled.
On the other hand poller.o will fail to link when slice.o is omitted.
I suggest we drop CONFIG_SLICE.
Best regards,
Daniel
--
Dipl.-Math. Daniel Glöckner, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11,
Gothaer Platz 3, 37083 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Heike Jordan, Dr. Uwe Kracke
Ust-IdNr.: DE 205 198 055
emlix - your embedded linux partner
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-05-08 18:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 7:54 [PATCH v4 00/11] Protect code from pollers Sascha Hauer
2020-04-22 7:54 ` [PATCH 01/11] poller: Give pollers a name Sascha Hauer
2020-04-22 7:54 ` [PATCH 02/11] poller: Add a poller command Sascha Hauer
2020-04-22 7:54 ` [PATCH 03/11] Introduce slices Sascha Hauer
2020-05-08 18:01 ` Daniel Glöckner [this message]
2020-05-11 6:40 ` Sascha Hauer
2020-04-22 7:54 ` [PATCH 04/11] net: Add a slice to struct eth_device Sascha Hauer
2020-04-22 7:54 ` [PATCH 05/11] net: mdiobus: Add slice Sascha Hauer
2020-04-22 7:54 ` [PATCH 06/11] usb: Add a slice to usb host controllers Sascha Hauer
2020-04-22 7:54 ` [PATCH 07/11] usbnet: Add slice Sascha Hauer
2020-04-22 7:54 ` [PATCH 08/11] net: Call net_poll() in a poller Sascha Hauer
2020-04-22 7:54 ` [PATCH 09/11] net: reply to ping requests Sascha Hauer
2020-04-22 7:54 ` [PATCH 10/11] usbnet: Be more friendly in the receive path Sascha Hauer
2020-04-22 7:54 ` [PATCH 11/11] poller: Allow to run pollers inside of pollers Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aca473b4-a4ef-1c8e-958f-dcec8044049d@emlix.com \
--to=dg@emlix.com \
--cc=barebox@lists.infradead.org \
--cc=eh@emlix.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox