Re: [PATCH] common: reset_source: Remove of_get_reset_source_priority()

[Michael Riesch <michael.riesch@wolfvision.net>]

Hi Alexander,

On 6/8/22 07:12, Alexander Shiyan wrote:
> of_get_reset_source_priority() has no users,
> so it can be safely removed.
> 
> Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
> ---
>  common/reset_source.c  | 20 +++-----------------
>  include/reset_source.h |  7 -------
>  2 files changed, 3 insertions(+), 24 deletions(-)
> 
> diff --git a/common/reset_source.c b/common/reset_source.c
> index 3554cbd0fb..dccb683231 100644
> --- a/common/reset_source.c
> +++ b/common/reset_source.c
> @@ -76,7 +76,9 @@ EXPORT_SYMBOL(reset_source_set_prinst);
>  
>  void reset_source_set_device(struct device_d *dev, enum reset_src_type st)
>  {
> -	int priority = of_get_reset_source_priority(dev->device_node);
> +	unsigned int priority = RESET_SOURCE_DEFAULT_PRIORITY;
> +
> +	of_property_read_u32(node, "reset-source-priority", &priority);

This seems to break my build:
barebox/common/reset_source.c:81:30: error: 'node' undeclared (first use
in this function)
   81 |         of_property_read_u32(node, "reset-source-priority",
&priority);
      |                              ^~~~

Should "node" be replaced by "dev->device_node"?

Best regards,
Michael

>  
>  	__reset_source_set(dev, st, priority, -1);
>  }
> @@ -92,19 +94,3 @@ static int reset_source_init(void)
>  	return 0;
>  }
>  coredevice_initcall(reset_source_init);
> -
> -/**
> - * of_get_reset_source_priority() - get the desired reset source priority from
> - *                                  device tree
> - * @node:	The device_node to read the property from
> - *
> - * return: The priority
> - */
> -unsigned int of_get_reset_source_priority(struct device_node *node)
> -{
> -	unsigned int priority = RESET_SOURCE_DEFAULT_PRIORITY;
> -
> -	of_property_read_u32(node, "reset-source-priority", &priority);
> -
> -	return priority;
> -}
> diff --git a/include/reset_source.h b/include/reset_source.h
> index 023b1fe4a0..a98c61ae0e 100644
> --- a/include/reset_source.h
> +++ b/include/reset_source.h
> @@ -32,8 +32,6 @@ void reset_source_set_device(struct device_d *dev, enum reset_src_type st);
>  void reset_source_set_prinst(enum reset_src_type,
>  			     unsigned int priority, int instance);
>  
> -unsigned int of_get_reset_source_priority(struct device_node *node);
> -
>  #else
>  
>  static inline enum reset_src_type reset_source_get(void)
> @@ -69,11 +67,6 @@ static inline void reset_source_set_prinst(enum reset_src_type type,
>  static inline void reset_source_set_instance(enum reset_src_type type, int instance)
>  {
>  }
> -
> -static inline unsigned int of_get_reset_source_priority(struct device_node *node)
> -{
> -	return 0;
> -}
>  #endif
>  
>  #define RESET_SOURCE_DEFAULT_PRIORITY 100

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox