From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYP7C-000879-9G for barebox@lists.infradead.org; Tue, 12 May 2020 07:14:11 +0000 References: <20200511072140.29610-1-a.fatoum@pengutronix.de> <20200511072140.29610-3-a.fatoum@pengutronix.de> <20200511100021.jtgei4uav4xbzd57@pengutronix.de> From: Ahmad Fatoum Message-ID: Date: Tue, 12 May 2020 09:14:07 +0200 MIME-Version: 1.0 In-Reply-To: <20200511100021.jtgei4uav4xbzd57@pengutronix.de> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 02/23] sandbox: define CONFIG_64BIT as appropriate To: Roland Hieber Cc: barebox@lists.infradead.org, Ahmad Fatoum Hi, On 5/11/20 12:00 PM, Roland Hieber wrote: > On Mon, May 11, 2020 at 09:21:19AM +0200, Ahmad Fatoum wrote: >> From: Ahmad Fatoum >> >> All 64-bit architectures are supposed to define CONFIG_64BIT to support >> the relevant 64-bit MMIO accessors. The sandbox architecture is a bit >> of a special case, because barebox uses the toolchain default and >> doesn't force a bitness. Add 64BIT as promptless symbol, which reflects >> the pointer size of the target platform. >> >> Signed-off-by: Ahmad Fatoum > > Nitpick: S-o-b address is different from the author address. > Same on the next patch. Ah, missed those. I can fix this in v2. Thanks Ahmad > > - Roland > >> --- >> arch/sandbox/Kconfig | 9 +++++++++ >> scripts/gcc-64bitptr.sh | 9 +++++++++ >> 2 files changed, 18 insertions(+) >> create mode 100755 scripts/gcc-64bitptr.sh >> >> diff --git a/arch/sandbox/Kconfig b/arch/sandbox/Kconfig >> index 6ec71a99e53f..46cfe8b4b1c8 100644 >> --- a/arch/sandbox/Kconfig >> +++ b/arch/sandbox/Kconfig >> @@ -1,3 +1,5 @@ >> +source "scripts/Kconfig.include" >> + >> config SANDBOX >> bool >> select OFTREE >> @@ -20,3 +22,10 @@ config SANDBOX_UNWIND >> default y >> select ARCH_HAS_STACK_DUMP >> depends on UBSAN || KASAN >> + >> +config CC_IS_64BIT >> + def_bool $(success,$(srctree)/scripts/gcc-64bitptr.sh $(CC)) >> + >> +config 64BIT >> + bool >> + default CC_IS_64BIT >> diff --git a/scripts/gcc-64bitptr.sh b/scripts/gcc-64bitptr.sh >> new file mode 100755 >> index 000000000000..7fb05703b813 >> --- /dev/null >> +++ b/scripts/gcc-64bitptr.sh >> @@ -0,0 +1,9 @@ >> +#!/bin/sh >> +# SPDX-License-Identifier: GPL-2.0-only >> + >> +cat << "END" | $@ -x c - -c -o /dev/null >> +int main(void) >> +{ >> + return sizeof(struct { int:-!(sizeof(void *) == 8); }); >> +} >> +END >> -- >> 2.26.2 >> >> >> _______________________________________________ >> barebox mailing list >> barebox@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/barebox >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox