From: Alexander Kurz <akurz@blala.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: barebox@lists.infradead.org
Subject: Re[2]: [PATCH] mfd mc13xxx: add MC13892_REVISION_2_4
Date: Thu, 18 Aug 2016 21:48:21 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.00.1608182142360.12656@blala.de> (raw)
In-Reply-To: <1471504820.129571485@f170.i.mail.ru>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1463 bytes --]
On Thu, 18 Aug 2016, Alexander Shiyan wrote:
> >Четверг, 18 августа 2016, 10:15 +03:00 от Sascha Hauer <s.hauer@pengutronix.de>:
> >
> >On Wed, Aug 17, 2016 at 03:12:19PM +0200, Alexander Kurz wrote:
> >> An MC13892CJ having REV[4:0]=0x14 can be found in the kindle-d01100.
> >> Add the revision to the list to support this device.
> >>
> >> Signed-off-by: Alexander Kurz < akurz@blala.de >
> >> ---
> >> drivers/mfd/mc13xxx.c | 1 +
> >> include/mfd/mc13xxx.h | 13 +++++++------
> >> 2 files changed, 8 insertions(+), 6 deletions(-)
> ...
> >> #define MC13892_REVISION_2_03
> >> #define MC13892_REVISION_2_0a4
> >> #define MC13892_REVISION_2_15
> >> -#define MC13892_REVISION_3_06
> >> -#define MC13892_REVISION_3_17
> >> -#define MC13892_REVISION_3_28
> >> -#define MC13892_REVISION_3_2a9
> >> -#define MC13892_REVISION_3_310
> >> -#define MC13892_REVISION_3_511
> >> +#define MC13892_REVISION_2_46
> >> +#define MC13892_REVISION_3_07
> >> +#define MC13892_REVISION_3_18
> >> +#define MC13892_REVISION_3_29
> >> +#define MC13892_REVISION_3_2a10
> >> +#define MC13892_REVISION_3_311
> >> +#define MC13892_REVISION_3_512
>
> Could this be converted to enum?
Personally I also prefer the enum since it enables e.g. gdb
awareness on the enum elements, depending on compiler and usecase
it may offer type and value range safety and in this case, the diff
would be smaller.
Is there a coding policy for barebox regarding macros vs. enums?
[-- Attachment #2: Type: text/plain, Size: 149 bytes --]
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-08-18 19:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 13:12 Alexander Kurz
2016-08-18 7:15 ` Sascha Hauer
2016-08-18 7:20 ` Re[2]: " Alexander Shiyan
2016-08-18 19:48 ` Alexander Kurz [this message]
2016-08-22 5:26 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1608182142360.12656@blala.de \
--to=akurz@blala.de \
--cc=barebox@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox