From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: "U-Boot Version 2 (barebox)" <barebox@lists.infradead.org>
Subject: RFC: first patch for getting arch-specific stuff out of asm-generic/barebox.lds.h
Date: Mon, 19 Nov 2012 08:53:45 -0500 (EST) [thread overview]
Message-ID: <alpine.DEB.2.02.1211190847250.11705@oneiric> (raw)
looking for comments on this patch as simply the *first* tweak to
start cleaning arch-specific content out of that barebox.lds.h.
here's the incredibly simple change to handle just x86:
===== start =====
diff --git a/arch/x86/lib/barebox.lds.S b/arch/x86/lib/barebox.lds.S
index 8bd2a7b..500fa91 100644
--- a/arch/x86/lib/barebox.lds.S
+++ b/arch/x86/lib/barebox.lds.S
@@ -16,6 +16,7 @@
*/
#undef i386
+#include <mach/barebox.lds.h>
#include <asm-generic/barebox.lds.h>
OUTPUT_FORMAT("elf32-i386", "elf32-i386", "elf32-i386")
diff --git a/include/asm-generic/barebox.lds.h b/include/asm-generic/barebox.lds.h
index b2bd19e..6e09de1 100644
--- a/include/asm-generic/barebox.lds.h
+++ b/include/asm-generic/barebox.lds.h
@@ -4,7 +4,6 @@
defined CONFIG_ARCH_IMX51 || \
defined CONFIG_ARCH_IMX53 || \
defined CONFIG_ARCH_IMX6 || \
- defined CONFIG_X86 || \
defined CONFIG_ARCH_EP93XX
#include <mach/barebox.lds.h>
#endif
===== end =====
of all the tests in the asm-generic file, the x86-related test is
unique in that it would end up including nothing but macro
definitions, so all the above does is remove that check from the
asm-generic file and explicitly put it into the x86 file -- it
*appears* that this has the same effect, and i tested it by building a
regular sandbox, which worked fine. (does that represent a reasonable
test?)
there's more that can be done, but the above at least gets rid of
one silly test in asm-generic/barebox.lds.h that doesn't need to be
there.
thoughts? if it looks reasonable, i can submit it as an official
patch.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
reply other threads:[~2012-11-19 13:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1211190847250.11705@oneiric \
--to=rpjday@crashcourse.ca \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox