From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: "U-Boot Version 2 (barebox)" <barebox@lists.infradead.org>
Subject: Re: [PATCH] Fix typo, "CFG_LONGHELP" -> "CONFIG_LONGHELP".
Date: Wed, 23 Dec 2009 04:06:00 -0500 (EST) [thread overview]
Message-ID: <alpine.LFD.2.00.0912230405001.11858@localhost> (raw)
In-Reply-To: <20091223090224.GO15126@pengutronix.de>
On Wed, 23 Dec 2009, Sascha Hauer wrote:
> Hi Robert,
>
> On Tue, Dec 22, 2009 at 09:51:19AM -0500, Robert P. J. Day wrote:
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> > while this fixes an obvious typo in this file, it's really just
> > a band-aid since this header file sets *numerous* CONFIG_-prefixed
> > macros, which it shouldn't be doing. any macros prefixed with
> > CONFIG_ should be reserved for the Kconfig namespace, so it
> > wouldn't hurt to apply this patch, but it's clear that this file
> > needs a lot more work at some point in the future.
>
> I used the eco920 during early development. We maybe have the
> opportunity to work on this board in the next time and then I'll fix
> this. Otherwise I tend to remove the board completely.
no problem. don't think you need to explain dropping any patch
submissions from me -- obviously, i don't know the history of the
software. whatever you decide.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
prev parent reply other threads:[~2009-12-23 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 14:51 Robert P. J. Day
2009-12-23 9:02 ` Sascha Hauer
2009-12-23 9:06 ` Robert P. J. Day [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0912230405001.11858@localhost \
--to=rpjday@crashcourse.ca \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox