From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 10 Jan 2023 17:42:16 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pFHhZ-007xgK-Cf for lore@lore.pengutronix.de; Tue, 10 Jan 2023 17:42:16 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFHhX-0008A3-5r for lore@pengutronix.de; Tue, 10 Jan 2023 17:42:15 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FWq4eSojvxTxox2RE2q5i3WHqiV6Y2GOQCWaI6WxtXI=; b=eTRitJdj+up3cC1opDAUvba2BW hT4caMdr5i8SzW+BrPLIQlE3ZIb7j2HQ9LvZzEM5omOKnKAvwMWw66BjZuiam6au+vHWQpXrH79dS wi5HyHMoA1WwQxgsWbA5bJdCyZp5tQzQ3oZkbF4o2jKAJg0V/Gd5mBKngTdp/kA4/fxM9qBLz3OGU Jmm4ur9AgB/wYVLzR6LyvPmFsSRA5l5CqgXqjkxyprPbb0P0wl+pLHUfCMZ4l1o7BJpFfJ5bYxHvl jCo6lc3I8AldrPIrL1ouSJtM+z9QWhp53HcbG4yA8RkGzFaIy+qrkMn06s1FS7QkjxQuTqkeYYXUd bIc1aWqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFHg4-007pKv-Tv; Tue, 10 Jan 2023 16:40:44 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFHg0-007pK4-I4 for barebox@lists.infradead.org; Tue, 10 Jan 2023 16:40:41 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pFHfz-0007r2-48; Tue, 10 Jan 2023 17:40:39 +0100 Message-ID: Date: Tue, 10 Jan 2023 17:40:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: Sascha Hauer Cc: barebox@lists.infradead.org References: <20230109160057.2223325-1-a.fatoum@pengutronix.de> <20230110144157.GJ28911@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20230110144157.GJ28911@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230110_084040_624376_78E515B5 X-CRM114-Status: GOOD ( 19.49 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.7 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] include: linux/iopoll.h: silence warning when timeout_us contains * X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) Hello Sascha, On 10.01.23 15:41, Sascha Hauer wrote: > On Mon, Jan 09, 2023 at 05:00:57PM +0100, Ahmad Fatoum wrote: >> We evaluate timeout_us for truthiness to determine whether we are >> entering an infinite poll loop. When timeout_us contains a >> multiplication, GCC will warn about it and suggest replacing the * >> with &&. Silence this warning by comparing directly against 0. >> >> Signed-off-by: Ahmad Fatoum >> --- >> include/linux/iopoll.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/iopoll.h b/include/linux/iopoll.h >> index 8bf912e173b3..b8c55583f97f 100644 >> --- a/include/linux/iopoll.h >> +++ b/include/linux/iopoll.h >> @@ -32,13 +32,13 @@ >> #define read_poll_timeout(op, val, cond, timeout_us, args...) \ >> ({ \ >> uint64_t start; \ >> - if (!IN_PBL && timeout_us) \ >> + if (!IN_PBL && timeout_us != 0) \ > > You should rather put timeout_us in brackets. Doesn't help: drivers/mtd/nand/atmel/nand-controller.c:279:51: warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context] 279 | timeout_ms * 1000); include/linux/iopoll.h:35:25: note: in definition of macro 'read_poll_timeout' 35 | if (!IN_PBL && (timeout_us)) \ | ^~~~~~~~~~ Ok to apply? Cheers, Ahmad > > Sascha > >> start = get_time_ns(); \ >> for (;;) { \ >> (val) = op(args); \ >> if (cond) \ >> break; \ >> - if (!IN_PBL && timeout_us && \ >> + if (!IN_PBL && timeout_us != 0 && \ >> is_timeout(start, ((timeout_us) * USECOND))) { \ >> (val) = op(args); \ >> break; \ >> -- >> 2.30.2 >> >> >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |