Re: [PATCH] automount: add nfs section to board automount scripts

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Jonas,

Thanks for your patch.

On 21.10.24 17:22, Jonas Rebmann wrote:
> When nfs automount was introduced in b31b7cf7e8b6, board specific

Nitpick: Kernel convention is to format commit hashes as
commit b31b7cf7e8b6 ("defaultenv-2: add automount for nfs").

> automount scripts where not updated

Nitpick: missing full stop.

> 
> ---
> Signed-off-by: Jonas Rebmann <jre@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Note that this will be cut off by git am, because it's under the ---.

Cheers,
Ahmad

> ---
>  arch/arm/boards/at91sam9m10ihd/env/init/automount                  | 5 ++++-
>  .../boards/efika-mx-smartbook/defaultenv-efikasb/init/automount    | 6 +++++-
>  .../boards/phytec-som-imx6/defaultenv-physom-imx6/init/automount   | 7 ++++++-
>  3 files changed, 15 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boards/at91sam9m10ihd/env/init/automount b/arch/arm/boards/at91sam9m10ihd/env/init/automount
> index 96ffa7059aa8f0013d88b3a9cf8522f2cfd94e2b..e7bb1e79b1acca59c8f2113cc443c83f63be689c 100644
> --- a/arch/arm/boards/at91sam9m10ihd/env/init/automount
> +++ b/arch/arm/boards/at91sam9m10ihd/env/init/automount
> @@ -5,7 +5,10 @@
>  mkdir -p /mnt/tftp
>  automount /mnt/tftp 'ifup eth0 && mount -t tftp $eth0.serverip /mnt/tftp'
>  
> -# automount nfs server example
> +# automount nfs server's nfsroot
> +
> +mkdir -p /mnt/nfs
> +automount /mnt/nfs 'ifup -a1 && mount -t nfs ${global.net.server}:/home/${global.user}/nfsroot/${global.hostname} /mnt/nfs'
>  
>  # SD card slot, first partition
>  mkdir -p /mnt/mmc
> diff --git a/arch/arm/boards/efika-mx-smartbook/defaultenv-efikasb/init/automount b/arch/arm/boards/efika-mx-smartbook/defaultenv-efikasb/init/automount
> index 71dfd95f2b9646d46809f12c283be3fa135ad410..9a6160231b27c133c8fb03883f44c7be22950d58 100644
> --- a/arch/arm/boards/efika-mx-smartbook/defaultenv-efikasb/init/automount
> +++ b/arch/arm/boards/efika-mx-smartbook/defaultenv-efikasb/init/automount
> @@ -5,7 +5,11 @@
>  mkdir -p /mnt/tftp
>  automount /mnt/tftp 'ifup eth0 && mount -t tftp $eth0.serverip /mnt/tftp'
>  
> -# automount nfs server example
> +# automount nfs server's nfsroot
> +
> +mkdir -p /mnt/nfs
> +automount /mnt/nfs 'ifup -a1 && mount -t nfs ${global.net.server}:/home/${global.user}/nfsroot/${global.hostname} /mnt/nfs'
> +
>  
>  # internal harddisk /boot partition
>  mkdir -p /mnt/internal-hd0.0
> diff --git a/arch/arm/boards/phytec-som-imx6/defaultenv-physom-imx6/init/automount b/arch/arm/boards/phytec-som-imx6/defaultenv-physom-imx6/init/automount
> index fea64d627e97e97ab4d819f532dc2f80da9247a9..16fa87fcb78ba90a1bc94908faf18c5f347e8ecc 100644
> --- a/arch/arm/boards/phytec-som-imx6/defaultenv-physom-imx6/init/automount
> +++ b/arch/arm/boards/phytec-som-imx6/defaultenv-physom-imx6/init/automount
> @@ -1,10 +1,15 @@
>  #!/bin/sh
>  
> -# automount tftp server based on $eth0.serverip
> +# automount tftp server
>  
>  mkdir -p /mnt/tftp
>  automount /mnt/tftp 'ifup eth0 && mount -t tftp $eth0.serverip /mnt/tftp'
>  
> +# automount nfs server's nfsroot
> +
> +mkdir -p /mnt/nfs
> +automount /mnt/nfs 'ifup -a && mount -t nfs ${global.net.server}:/home/${global.user}/nfsroot/${global.hostname} /mnt/nfs'
> +
>  mkdir -p /mnt/mmc
>  automount -d /mnt/mmc 'mmc2.probe=1 && [ -e /dev/mmc2.0 ] && mount /dev/mmc2.0 /mnt/mmc'
>  
> 
> ---
> base-commit: dda64a15ea026c95ccd8bd8a8b70c7e070af1a15
> change-id: 20241021-phytec-nfs-automount-8f1a06171c82
> 
> Best regards,


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |