From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org, Felix Singer <felixsinger@posteo.net>
Subject: Re: [PATCH 10/13] images: add barebox FIT image target
Date: Fri, 17 Jan 2025 10:03:20 +0100 [thread overview]
Message-ID: <b5506841-68f9-496b-9b59-8c9d5fbe0d77@pengutronix.de> (raw)
In-Reply-To: <Z4oVpYra9gKbDoGM@pengutronix.de>
Hello Sascha,
On 17.01.25 09:32, Sascha Hauer wrote:
> Hi Ahmad,
>
> On Sun, Jan 12, 2025 at 09:34:29AM +0100, Ahmad Fatoum wrote:
>> +MAKE_FIT := $(srctree)/scripts/make_fit.py
>> +
>> +# Use this to override the compression algorithm of the DTBs
>> +FIT_COMPRESSION ?= none
>> +
>> +quiet_cmd_fit = FIT $@
>> + cmd_fit = $(MAKE_FIT) -o $@ --arch $(CONFIG_ARCH_MKIMAGE_NAME) --os linux \
>> + --name 'barebox-$(KERNELRELEASE)' \
>> + $(if $(findstring 1,$(KBUILD_VERBOSE)),-v) \
>> + $(if $(FIT_DECOMPOSE_DTBS),--decompose-dtbs) \
>> + --dtb-compress $(FIT_COMPRESSION) -k $< @$(word 2,$^)
>
> I had to drop this and the following patches from this series.
>
> barebox already has a cmd_fit which you are overwriting with this patch.
> The existing FIT target is used for the beagleplay board to build an
> image to be started from U-Boot. I suspect we can just replace existing
> FIT target with your version.
I renamed it to cmd_itb in this patch that you picked:
https://lore.kernel.org/all/20250106091935.3435710-1-a.fatoum@pengutronix.de/
Cheers,
Ahmad
>
> Sascha
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-01-17 9:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-12 8:34 [PATCH 00/13] " Ahmad Fatoum
2025-01-12 8:34 ` [PATCH 01/13] ARM: dts: add device trees for the QEMU Virt machine Ahmad Fatoum
2025-01-12 8:34 ` [PATCH 02/13] treewide: collect the name of all board device trees Ahmad Fatoum
2025-01-12 8:34 ` [PATCH 03/13] kbuild: collect available device trees in dtbs-list Ahmad Fatoum
2025-01-12 8:34 ` [PATCH 04/13] scripts: add new scripts_dtc target Ahmad Fatoum
2025-01-12 8:34 ` [PATCH 05/13] kbuild: restrict dtbs target to enabled DTs by default Ahmad Fatoum
2025-01-12 8:34 ` [PATCH 06/13] kbuild: improve make help description Ahmad Fatoum
2025-01-12 8:34 ` [PATCH 07/13] kbuild: allow dependency on any file in images/ Ahmad Fatoum
2025-01-12 8:34 ` [PATCH 08/13] arch: maintain Linux kernel and mkimage ARCH mapping in Kconfig Ahmad Fatoum
2025-01-12 8:34 ` [PATCH 09/13] arch: make BOARD_GENERIC_DT a user-selectable option across archs Ahmad Fatoum
2025-01-12 8:34 ` [PATCH 10/13] images: add barebox FIT image target Ahmad Fatoum
2025-01-17 8:32 ` Sascha Hauer
2025-01-17 9:03 ` Ahmad Fatoum [this message]
2025-01-20 7:19 ` Sascha Hauer
2025-01-12 8:34 ` [PATCH 11/13] MAKEALL: rename target in symbols to more appropiate defconfig Ahmad Fatoum
2025-01-12 8:34 ` [PATCH 12/13] MAKEALL: add support for building arbitrary targets Ahmad Fatoum
2025-01-12 8:34 ` [PATCH 13/13] ci: container: add python3-libfdt dependency for barebox.fit Ahmad Fatoum
2025-01-14 8:18 ` [PATCH 00/13] images: add barebox FIT image target Sascha Hauer
2025-01-21 8:07 ` (subset) " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5506841-68f9-496b-9b59-8c9d5fbe0d77@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=felixsinger@posteo.net \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox