From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 13 Jun 2023 09:50:44 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q8ynd-004tP0-Ot for lore@lore.pengutronix.de; Tue, 13 Jun 2023 09:50:44 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8yna-0004PV-Tp for lore@pengutronix.de; Tue, 13 Jun 2023 09:50:43 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uv4rHWOh1xOXua7fNF6ZI9iXHLAK7PrbhnnR2DmM8tg=; b=cHZcaHjfDbx8Pkfce061/kj2/a x2bcJ7bxcOss9TlwQhgV4JoIM6C3szVIazYOFEueClGMSX+i1ntVcpFc9cqCGtaSrREEOQ/erJpAt ZylSerlZjrNfwQigtCqbXYFtoBFuG8/X50cf4pH8KUoPbAuWsDD1MKB3mMqYROxHM/nF0ZFkk+ntc sCP3G5YaapAw2cScxoqzojkt6Tc9IBYDTzgxUMIpqZ8flWSCCLZdWy4oOfk+RN1yStXkHVHaHnzfD b1edIMgb6SnDrThwyfKDdjt9erqP4MInbOZADmDlekB3z0Cn8IWZyPhkc4NEqPvAPIyBMHY9i2OPL fK74ogoA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8yme-007GxJ-26; Tue, 13 Jun 2023 07:49:44 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q8ymb-007GwV-0p for barebox@lists.infradead.org; Tue, 13 Jun 2023 07:49:42 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q8ymZ-0003yt-Vs; Tue, 13 Jun 2023 09:49:40 +0200 Message-ID: Date: Tue, 13 Jun 2023 09:49:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Content-Language: en-US To: Marco Felsch , barebox@lists.infradead.org Cc: Jules Maselbas References: <20230602074921.2687669-1-m.felsch@pengutronix.de> <20230602074921.2687669-10-m.felsch@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20230602074921.2687669-10-m.felsch@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230613_004941_294485_AA3121B1 X-CRM114-Status: GOOD ( 18.60 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 09/10] OF: gpio: fix device_node leakage X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 02.06.23 09:49, Marco Felsch wrote: > Drop the device_node after we are done. > > Signed-off-by: Marco Felsch There's no leakage fixed here. of_node_put is a no-op in barebox and even in the kernel, it only does reference counting when CONFIG_OF_DYNAMIC=y. I don't mind if change is to align with kernel, so with commit message reworded: Reviewed-by: Ahmad Fatoum > --- > drivers/of/of_gpio.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/of/of_gpio.c b/drivers/of/of_gpio.c > index c20133bbfd..76398f7542 100644 > --- a/drivers/of/of_gpio.c > +++ b/drivers/of/of_gpio.c > @@ -76,16 +76,17 @@ int of_get_named_gpio_flags(struct device_node *np, const char *propname, > if (!dev) { > pr_debug("%s: unable to find device of node %s\n", > __func__, gpiospec.np->full_name); > - return -EPROBE_DEFER; > + ret = -EPROBE_DEFER; > + goto out; > } > > ret = gpio_get_num(dev, gpiospec.args[0]); > if (ret == -EPROBE_DEFER) > - return ret; > + goto out; > if (ret < 0) { > pr_err("%s: unable to get gpio num of device %s: %d\n", > __func__, dev_name(dev), ret); > - return ret; > + goto out; > } > > if (flags) { > @@ -93,6 +94,9 @@ int of_get_named_gpio_flags(struct device_node *np, const char *propname, > of_gpio_flags_quirks(np, propname, flags, index); > } > > +out: > + of_node_put(gpiospec.np); > + > return ret; > } > EXPORT_SYMBOL(of_get_named_gpio_flags); -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |