From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 20 Apr 2021 11:24:14 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lYmcA-0008Me-OZ for lore@lore.pengutronix.de; Tue, 20 Apr 2021 11:24:14 +0200 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lYmc9-0006Ak-Pw for lore@pengutronix.de; Tue, 20 Apr 2021 11:24:14 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fiTNRn0RDHwfv+wjY0KIYzoMe2KxaDWUAS8ePu+8GH4=; b=ErivqPLCO65JOKCbgUOyW1AzM pqRxaiO0186PM+1Bt5mjmo9M6UEcAzKjUaja23bnoiBOh54pC4Sp7xRyQpdLrOWF1ykUnSvCIne1u 9CjzEqDoGLuO3R5BKTYE3zUxIfuI0FL4TL2lo4D4JRdqBppWjK2VSOeS5baIP/pS37/UpvjqRJ6Sx 2EdmEKR4W2uFVfGxVEVix9jlqT1k0KYY8ti4gChTSHIcW2tAnWtjecF1Z7YLvdZ2jCVi95BNnS0YO yC1z/AUo8K3hAneBXenHGogWLsNuBhk9qkGqnvansDze7xTtNoIiQRHU75cdYQCE/giFqq2Oc5fmo vnGhMHy8A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYmbD-00BizA-TP; Tue, 20 Apr 2021 09:23:16 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYmb4-00BiyS-Q9 for barebox@desiato.infradead.org; Tue, 20 Apr 2021 09:23:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To: Subject:Sender:Reply-To:Cc:Content-ID:Content-Description; bh=8c+u7S51xLIEax8RYwarHKLn3rv6RsyXvz++knOtrns=; b=CtHcNtFag24civpGBxMkvEdQOa uCZXgkkGEJcTMV3+FAvMs+pZrrcvy9w7EJGBTlAYjhYkRFNjHbDNpggjJS2wOcjwep20c8ddgBVd4 OBZYI8XMBLQyRpqDZX/LfaYmaS4ZSgJD1bBk/W1B03i6w/6+eR14E3NGzAdvzZXxTIedr+5Arrzyv Vrx9SxcWDWCvd5ypHJkB8lcnVrGXRMNL2UOZFOcFppuHJ1P2wcb3cXEnlIMeI6YpjNXrnqWVVQTfh 9T4JwDXAlKJGbnwBLolJYcfy4WAdf5cgLS+YD87i+cgJRl6SBEP7qDk4+RQP8eoRvmu17XvEIOjbu 3SDmwEww==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYmb2-00ByQC-1m for barebox@lists.infradead.org; Tue, 20 Apr 2021 09:23:05 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lYmb0-00064U-Rs; Tue, 20 Apr 2021 11:23:02 +0200 To: Rouven Czerwinski , barebox@lists.infradead.org References: <20210420075700.246124-1-r.czerwinski@pengutronix.de> <20210420075700.246124-5-r.czerwinski@pengutronix.de> From: Ahmad Fatoum Message-ID: Date: Tue, 20 Apr 2021 11:23:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210420075700.246124-5-r.czerwinski@pengutronix.de> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210420_022304_148209_9600FABA X-CRM114-Status: GOOD ( 26.34 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2001:8b0:10b:1:d65d:64ff:fe57:4e05 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.3 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 5/8] of: add reserved_mem_read initcall X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) Hi, On 20.04.21 09:56, Rouven Czerwinski wrote: > Add a reserved_mem_read initcall which parses the reserved-memory > entries and adds barebox of reserve entries. Also remove the OP-TEE size > of reserve entry, since this is now parsed from the DT and does not need > to be statically configured any longer. > > Signed-off-by: Rouven Czerwinski > --- > arch/arm/cpu/start.c | 3 --- > drivers/of/Makefile | 1 + > drivers/of/reserved-mem.c | 41 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 42 insertions(+), 3 deletions(-) > create mode 100644 drivers/of/reserved-mem.c > > diff --git a/arch/arm/cpu/start.c b/arch/arm/cpu/start.c > index 10ac070fe3..811de056c0 100644 > --- a/arch/arm/cpu/start.c > +++ b/arch/arm/cpu/start.c > @@ -226,9 +226,6 @@ __noreturn __no_sanitize_address void barebox_non_pbl_start(unsigned long membas > > mem_malloc_init((void *)malloc_start, (void *)malloc_end - 1); > > - if (IS_ENABLED(CONFIG_BOOTM_OPTEE)) > - of_add_reserve_entry(endmem - OPTEE_SIZE, endmem - 1, OF_RESERVE_ENTRY_FLAG_XN); > - > pr_debug("starting barebox...\n"); > > start_barebox(); > diff --git a/drivers/of/Makefile b/drivers/of/Makefile > index b6847752d2..749fe16a2a 100644 > --- a/drivers/of/Makefile > +++ b/drivers/of/Makefile > @@ -4,6 +4,7 @@ obj-$(CONFIG_OF_GPIO) += of_gpio.o > obj-$(CONFIG_OF_PCI) += of_pci.o > obj-y += partition.o > obj-y += of_net.o > +obj-y += reserved-mem.o obj-$(CONFIG_OFDEVICE) > obj-$(CONFIG_MTD) += of_mtd.o > obj-$(CONFIG_OF_BAREBOX_DRIVERS) += barebox.o > obj-$(CONFIG_OF_OVERLAY) += overlay.o resolver.o of_firmware.o > diff --git a/drivers/of/reserved-mem.c b/drivers/of/reserved-mem.c > new file mode 100644 > index 0000000000..ee15ae880c > --- /dev/null > +++ b/drivers/of/reserved-mem.c > @@ -0,0 +1,41 @@ > +#include > +#include > +#include Is this header used here? > +#include > +#include > +#include > +#include > + > +static int reserved_mem_read(void) > +{ > + struct device_node *node, *child; > + struct resource resource; > + int flag; > + > + node = of_get_root_node(); > + if (!node) > + return 0; Unneeded check. of_find_node_by_path takes care of this. > + > + node = of_find_node_by_path("/reserved-memory"); > + if (!node) > + return 0; > + > + for_each_child_of_node(node, child) { > + flag = OF_RESERVE_ENTRY_FLAG_NO_RESERVE; > + > + of_address_to_resource(child, 0, &resource); > + > + pr_err("Res-Mem start: 0x%08x\n", resource.start); > + pr_err("Res-Mem end: 0x%08x\n", resource.end); pr_debug? > + > + if(of_find_property(child, "no-map", 0)) { Whitespace ;) > + pr_err("Res-Mem: no-map\n"); > + flag |= OF_RESERVE_ENTRY_FLAG_XN; > + } > + > + of_add_reserve_entry(resource.start, resource.end, flag); > + } > + > + return 0; > +} > +postconsole_initcall(reserved_mem_read); I think this should be postcore_initcall > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox