mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: <Oleg.Karfich@wago.com>
To: s.hauer@pengutronix.de
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] net: dhcp: add global variable for retries
Date: Tue, 4 Sep 2018 07:02:16 +0000	[thread overview]
Message-ID: <bd81894f-fe0d-a9b3-d5dd-fd4d1ecb61a3@wago.com> (raw)
In-Reply-To: <20180904061232.agbtqsxaqemjd6b2@pengutronix.de>

On 04.09.2018 08:12, Sascha Hauer wrote:
> Hi Oleg,

Hi Sascha,

> 
> On Fri, Aug 31, 2018 at 09:01:32AM +0000, Oleg.Karfich@wago.com wrote:
>> Signed-off-by: Oleg Karfich <oleg.karfich@wago.com>
>> ---
>>  net/dhcp.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/net/dhcp.c b/net/dhcp.c
>> index 6394397..92e0501 100644
>> --- a/net/dhcp.c
>> +++ b/net/dhcp.c
>> @@ -448,6 +448,7 @@ static char *global_dhcp_bootfile;
>>  static char *global_dhcp_oftree_file;
>>  static char *global_dhcp_rootpath;
>>  static char *global_dhcp_tftp_server_name;
>> +static char *global_dhcp_retries;
>>  static char *global_dhcp_option224;
>>  
>>  static void set_res(char **var, const char *res)
>> @@ -629,6 +630,7 @@ static int dhcp_global_init(void)
>>  	globalvar_add_simple_string("dhcp.user_class", &global_dhcp_user_class);
>>  	globalvar_add_simple_string("dhcp.oftree_file", &global_dhcp_oftree_file);
>>  	globalvar_add_simple_string("dhcp.tftp_server_name", &global_dhcp_tftp_server_name);
>> +	globalvar_add_simple_string("dhcp.retries", &global_dhcp_retries);
> 
> This adds a global variable, but it is not used, so this still has no
> effect. Turn this into globalvar_add_simple_int(). The int * you pass
> should then be used instead of DHCP_DEFAULT_RETRY to initialize
> dhcp_param.retries in dhcp_request().


Oh...there went something totaly wrong. Sorry for that...V2 is coming

> 
> Sascha
> 

Regard
Oleg
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-09-04  7:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-31  9:01 [PATCH 0/3] extend dhcp functionality Oleg.Karfich
2018-08-31  9:01 ` [PATCH 2/3] commands: dhcp: add parameter for private data Oleg.Karfich
2018-08-31  9:01 ` [PATCH 3/3] net: dhcp: add global variable for retries Oleg.Karfich
2018-09-04  6:12   ` Sascha Hauer
2018-09-04  7:02     ` Oleg.Karfich [this message]
2018-08-31  9:01 ` [PATCH 1/3] net: dhcp: use private extension 224 also in discover requests Oleg.Karfich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd81894f-fe0d-a9b3-d5dd-fd4d1ecb61a3@wago.com \
    --to=oleg.karfich@wago.com \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox