From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 13 Jun 2023 09:38:39 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q8ybw-004swD-KF for lore@lore.pengutronix.de; Tue, 13 Jun 2023 09:38:39 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8ybu-00020r-4c for lore@pengutronix.de; Tue, 13 Jun 2023 09:38:38 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XaIgpbY9dGCodx999K9E0TzoY64+9v7CEJ7cAhldBMY=; b=mjf6SH4GFnqNJ3INyQnCPqW9rt ug1fT0BzD9d3KekcciwtP0pOqRq2322OFSU/r3Uj6DUMMtnHHoQ/0mGM3T7rsobeIq1Fv6mwwCZgB /PyaDFxRVvtg3RVsJNqhvXiwFLfjv/3ltJ2GSa/qwPGZT8vz7/zJ0Kbq7WXi77PP9zFNzeujAnm6u VVeYDR4hKeRJV6Gfc/g+7GQ0+xz4qjbsv4eaDcTgh4nC3Wq0V4SyPdR4im9E6pcS/XQP6H21y8hVv nbK30ZVpoB48LAKB95NAJciK6pbwuV/bs3vkMmzrT1k7OsNDsB7TBQg1P2rOOg8Ie0utjOcpoPXgz d6qZ+fTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q8yaw-007ETz-1i; Tue, 13 Jun 2023 07:37:38 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q8yat-007ESq-1w for barebox@lists.infradead.org; Tue, 13 Jun 2023 07:37:37 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q8yas-0001qq-B9; Tue, 13 Jun 2023 09:37:34 +0200 Message-ID: Date: Tue, 13 Jun 2023 09:37:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Content-Language: en-US To: Marco Felsch , barebox@lists.infradead.org Cc: Jules Maselbas References: <20230602074921.2687669-1-m.felsch@pengutronix.de> <20230602074921.2687669-3-m.felsch@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20230602074921.2687669-3-m.felsch@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230613_003735_641025_3DBF5458 X-CRM114-Status: GOOD ( 20.12 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 02/10] gpiolib: simplify for loop break condition X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) On 02.06.23 09:49, Marco Felsch wrote: > No functional change just a simplification to align it with the Linux > kernel. Also add the kernel comment to make the reason clear. > > Signed-off-by: Marco Felsch Reviewed-by: Ahmad Fatoum > --- > drivers/gpio/gpiolib.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index b4a3a4e550..0df43c9f8f 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -529,7 +529,15 @@ static int of_gpiochip_scan_hogs(struct gpio_chip *chip) > of_property_read_string_array(chip->dev->of_node, > "gpio-line-names", arr, count); > > - for (i = 0; i < chip->ngpio && i < count; i++) > + /* > + * Since property 'gpio-line-names' cannot contains gaps, we > + * have to be sure we only assign those pins that really exists > + * since chip->ngpio can be less. > + */ > + if (count > chip->ngpio) > + count = chip->ngpio; > + > + for (i = 0; i < count; i++) > gpio_desc[chip->base + i].name = xstrdup(arr[i]); > > free(arr); -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |