Re: [PATCH 2/2] of: partition: Use mtd partitioning for of_fixup instead of the cdev variant

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]

Hello,

On Fri, Mar 08, 2024 at 10:27:21AM +0100, Ahmad Fatoum wrote:
> On 08.03.24 10:15, Uwe Kleine-König wrote:
> > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > 
> > It was already noticed in commit 9d42c77f126e ("devfs: take into account
> > for the partitions check that mtd is different") that the partitioning
> > info is stored differently for mtd devices. Instead of only getting the
> > partion size from the right spot, use the right data completely.
> 
> I read both this commit message and that of the referenced commit and I
> don't quite understand what the issue is. Could you add a short sentence
> about what particular issue this fix addresses?

The situation fixed here is:

After bootup the partitioning information for mtd devices exists in both
locations (cdev->partitions and cdev->mtd->partitions). An interactive
addpart only adds the the latter. This patch fixes the of fixup to also
use the latter.

In the described error case the partition added to the bootup layout
(defined in the dtb) doesn't make it into the device tree provided to
Linux.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]