From: Philipp Zabel <p.zabel@pengutronix.de>
To: Sascha Hauer <sha@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 2/3] video: fbconsole: add optional damage tracking
Date: Wed, 05 Apr 2023 14:27:16 +0200 [thread overview]
Message-ID: <c014e29c02e3ef16fbdfb79ae3fb27b047eb21a6.camel@pengutronix.de> (raw)
In-Reply-To: <20230405111356.GZ19113@pengutronix.de>
On Mi, 2023-04-05 at 13:13 +0200, Sascha Hauer wrote:
> On Mon, Apr 03, 2023 at 02:18:43PM +0200, Philipp Zabel wrote:
[...]
> > + gu_screen_blit_area(priv->sc, rect.x1, rect.y1,
> > priv->font->width, priv->font->height);
> > + fb_damage(priv->fb, &rect);
>
> Does it make sense to call fb_damage() from gu_screen_blit_area() and
> gu_screen_blit() instead?
Makes sense to me, changed in v2.
regards
Philipp
next prev parent reply other threads:[~2023-04-05 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 12:18 [PATCH 1/3] video: fb: " Philipp Zabel
2023-04-03 12:18 ` [PATCH 2/3] video: fbconsole: " Philipp Zabel
2023-04-05 11:13 ` Sascha Hauer
2023-04-05 12:27 ` Philipp Zabel [this message]
2023-04-03 12:18 ` [PATCH 3/3] video: mipi_dbi: add damage tracking and partial updates Philipp Zabel
2023-04-04 12:24 ` [PATCH 1/3] video: fb: add optional damage tracking Ahmad Fatoum
2023-04-05 12:26 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c014e29c02e3ef16fbdfb79ae3fb27b047eb21a6.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox