From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 07 May 2021 13:46:52 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1leywW-0004Q7-RU for lore@lore.pengutronix.de; Fri, 07 May 2021 13:46:52 +0200 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leywV-0002Ge-Na for lore@pengutronix.de; Fri, 07 May 2021 13:46:52 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G3J5j0eGJPzejnDeM6E9Tg09EPLge4Q3ZjF1wxtt7xo=; b=q6nO0pLfUOqGHivfiFeHRNxjx FNF+f0OKBMOdeUpz/pyEW12aRRiZ8zmYAjGQbAnrHuz50t1qfnveyL+WofKMtakiwLREs4+gsLWSo CSwBZx4A+Kuq/Z169DIShpUWkIVscNjThCx8E9iYoxhTLd1yhu4wS9m6zE8+gUXGnpqgguL2qyYIy JbfcLcCm5e8uYE+LmVMgTv8lxtUk2ZCOgaY8w881bSixfXXs3VEPp5BM8T5b7n8cpENcZMon+N5d3 uIUoebQZt2Zc/WnIZGFZOJOvVhvYhrp8pvqVQv0HAoLiN2VHqRh5gB+YbCi7k1DvWNeYD7G+32dH6 bHL5WH9lQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1leyvm-0070JM-0W; Fri, 07 May 2021 11:46:06 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leyvh-0070J6-MT for barebox@desiato.infradead.org; Fri, 07 May 2021 11:46:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=NehEOAix7D06188xVkQQ8iN+CiPymVb+DuzYFvZJZHk=; b=VEJP6lox+hAxGpL4NWhV4DVLwA MufrW2Zekw+NzH1jWcB2I0VfG+TAwuv4sP37NjVz1r7BBFFI0Bb1a7GP1ycAydhCDXy8Fzs1ZY21o OzE3LPH/m780ykg3ISkAgz6qZDkWFiGBvwr/GxaBxxRomHinyN5yPGQvgdSseP5Qe/kwpZmFRfS2q m0YZ/J5vbmgDgoD4yIuYz7l3HRR8KjxztaEql2ESjdgS2r+isZqGeBjQPR7navMMuHChG9rHbUi+9 dgpNpsX5pRSrGj4Lvdt5rgDmbT9YnzAiKfhVxvDpxECboyMEBEJMtsHm/aozjTEawdlrHyKIQk5/2 dhNM+I5Q==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1leyve-006pNO-RR for barebox@lists.infradead.org; Fri, 07 May 2021 11:46:00 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1leyvd-00025B-3m; Fri, 07 May 2021 13:45:57 +0200 To: Antony Pavlov , barebox@lists.infradead.org References: <20210506220834.223350-1-antonynpavlov@gmail.com> <20210506220834.223350-6-antonynpavlov@gmail.com> From: Ahmad Fatoum Message-ID: Date: Fri, 7 May 2021 13:45:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210506220834.223350-6-antonynpavlov@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210507_044558_934002_AFEF342C X-CRM114-Status: GOOD ( 25.01 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" X-SA-Exim-Connect-IP: 2001:8b0:10b:1:d65d:64ff:fe57:4e05 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.6 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v2 05/11] serial: add litex UART driver X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) Hi, On 07.05.21 00:08, Antony Pavlov wrote: > Signed-off-by: Antony Pavlov > --- > drivers/serial/Makefile | 1 + > drivers/serial/serial_litex.c | 96 +++++++++++++++++++++++++++++++++++ > 2 files changed, 97 insertions(+) > > diff --git a/drivers/serial/Makefile b/drivers/serial/Makefile > index 5120b17376..45055371ea 100644 > --- a/drivers/serial/Makefile > +++ b/drivers/serial/Makefile > @@ -24,3 +24,4 @@ obj-$(CONFIG_DRIVER_SERIAL_DIGIC) += serial_digic.o > obj-$(CONFIG_DRIVER_SERIAL_LPUART) += serial_lpuart.o > obj-$(CONFIG_VIRTIO_CONSOLE) += virtio_console.o > obj-$(CONFIG_SERIAL_SIFIVE) += serial_sifive.o > +obj-$(CONFIG_SOC_LITEX) += serial_litex.o > diff --git a/drivers/serial/serial_litex.c b/drivers/serial/serial_litex.c > new file mode 100644 > index 0000000000..8562a45ecc > --- /dev/null > +++ b/drivers/serial/serial_litex.c > @@ -0,0 +1,96 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2019 Antony Pavlov > + * > + */ > + > +#include > +#include > +#include > + > +#define UART_RXTX 0x00 > +#define UART_TXFULL 0x04 > +#define UART_RXEMPTY 0x08 > +#define UART_EV_PENDING 0x10 > +#define UART_EV_RX (1 << 1) > + > +static inline uint32_t litex_serial_readb(struct console_device *cdev, > + uint32_t offset) > +{ > + void __iomem *base = cdev->dev->priv; > + > + return readb(base + offset); > +} > + > +static inline void litex_serial_writeb(struct console_device *cdev, > + uint32_t value, uint32_t offset) > +{ > + void __iomem *base = cdev->dev->priv; > + > + writeb(value, base + offset); > +} > + > +static void litex_serial_putc(struct console_device *cdev, char c) > +{ > + while (litex_serial_readb(cdev, UART_TXFULL)) > + ; > + > + litex_serial_writeb(cdev, c, UART_RXTX); > +} > + > +static int litex_serial_getc(struct console_device *cdev) > +{ > + int c; > + > + while (litex_serial_readb(cdev, UART_RXEMPTY)) > + ; > + > + c = litex_serial_readb(cdev, UART_RXTX); > + > + /* refresh UART_RXEMPTY by writing UART_EV_RX to UART_EV_PENDING */ > + litex_serial_writeb(cdev, UART_EV_RX, UART_EV_PENDING); > + > + return c; > +} > + > +static int litex_serial_tstc(struct console_device *cdev) > +{ > + return !litex_serial_readb(cdev, UART_RXEMPTY); > +} > + > +static int litex_serial_probe(struct device_d *dev) > +{ > + struct resource *iores; > + struct console_device *cdev; > + > + cdev = xzalloc(sizeof(struct console_device)); > + iores = dev_request_mem_resource(dev, 0); > + if (IS_ERR(iores)) > + return PTR_ERR(iores); > + > + dev->priv = IOMEM(iores->start); > + cdev->dev = dev; > + cdev->tstc = &litex_serial_tstc; > + cdev->putc = &litex_serial_putc; > + cdev->getc = &litex_serial_getc; > + cdev->setbrg = NULL; Does the IP only output a fixed baudrate/configuration? > + > + console_register(cdev); > + > + return 0; > +} > + > +static __maybe_unused struct of_device_id litex_serial_dt_ids[] = { > + { > + .compatible = "litex,uart", > + }, { > + /* sentinel */ > + } > +}; > + > +static struct driver_d litex_serial_driver = { > + .name = "litex-uart", > + .probe = litex_serial_probe, > + .of_compatible = DRV_OF_COMPAT(litex_serial_dt_ids), > +}; > +console_platform_driver(litex_serial_driver); > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox