From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH 3/3] remoteproc: add .stop device parameter for stopping remote processor
Date: Mon, 25 Nov 2019 10:45:01 +0100 [thread overview]
Message-ID: <c53d29c2-8f71-c0be-21bc-3dc75990222e@pengutronix.de> (raw)
In-Reply-To: <20191125082848.2rkmumxerinj4oa5@pengutronix.de>
On 11/25/19 9:28 AM, Sascha Hauer wrote:
> On Thu, Nov 21, 2019 at 09:40:05AM +0100, Ahmad Fatoum wrote:
>> Both the STM32 and i.MX7 remote proc drivers populate the .stop member
>> in the struct rproc, but it's not used anywhere.
>
> The .stop member in struct rproc is introduced in this patch.
Indeed. I was referring to the stop member in the ops struct, which is
a so-far unused function pointer.
>> ret = rproc_start(rproc, &fw);
>> + if (ret == 0)
>> + rproc->stop = PARAM_TRISTATE_FALSE;
>
> Can we use positive logic here? "Status Stopped is false" is harder to
> read than just "running" or "started".
Naming it .stop emphasizes the fact that it's only meant to stop execution,
not start it. See below.
>> + return stop(rproc);
>> +}
>
> I would assume that when I can stop the remote processor with this
> parameter I should be able to start it here as well, no?
Which firmware would the processor execute when started via parameter?
I see no benefit in powering up the co-processor without specifying a
firmware image.
Thoughts?
Ahmad
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2019-11-25 9:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 8:40 [PATCH 1/3] param: add dev_add_param_tristate(_ro) helpers Ahmad Fatoum
2019-11-21 8:40 ` [PATCH 2/3] watchdog: core: use new dev_add_param_tristate helper for .running param Ahmad Fatoum
2019-11-21 8:40 ` [PATCH 3/3] remoteproc: add .stop device parameter for stopping remote processor Ahmad Fatoum
2019-11-25 8:28 ` Sascha Hauer
2019-11-25 9:45 ` Ahmad Fatoum [this message]
2019-12-04 13:07 ` Ahmad Fatoum
2019-12-05 8:10 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c53d29c2-8f71-c0be-21bc-3dc75990222e@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox