Re: [PATCH 4/8] ARM: i.MX: imx8-ddrc: Remove debug code

[Rouven Czerwinski <r.czerwinski@pengutronix.de>]

On Thu, 2019-08-22 at 14:51 +0200, Sascha Hauer wrote:
> various puthex_ll() printed values without any context are not
> helpful when
> debugging unrelated stuff, so remove them. When they are really
> needed
> they should be added with proper pr_debug() statements.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  arch/arm/mach-imx/imx8-ddrc.c | 20 ++------------------
>  1 file changed, 2 insertions(+), 18 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/imx8-ddrc.c b/arch/arm/mach-imx/imx8-
> ddrc.c
> index 736865eb6f..8bb2672102 100644
> --- a/arch/arm/mach-imx/imx8-ddrc.c
> +++ b/arch/arm/mach-imx/imx8-ddrc.c
> @@ -69,15 +69,8 @@ static void ddrc_phy_fetch_streaming_message(void
> __iomem *phy)
>  	const u16 index = ddrc_phy_get_message(phy,
> PMC_MESSAGE_STREAM);
>  	u16 i;
>  
> -	putc_ll('|');
> -	puthex_ll(index);
> -
> -	for (i = 0; i < index; i++) {
> -		const u32 arg = ddrc_phy_get_message(phy,
> PMC_MESSAGE_STREAM);
> -
> -		putc_ll('|');
> -		puthex_ll(arg);
> -	}
> +	for (i = 0; i < index; i++)
> +		ddrc_phy_get_message(phy, PMC_MESSAGE_STREAM);
>  }
>  
>  void ddrc_phy_wait_training_complete(void __iomem *phy)
> @@ -85,23 +78,14 @@ void ddrc_phy_wait_training_complete(void __iomem
> *phy)
>  	for (;;) {
>  		const u32 m = ddrc_phy_get_message(phy,
> PMC_MESSAGE_ID);
>  
> -		puthex_ll(m);
> -
>  		switch (m) {
>  		case PMC_TRAIN_STREAM_START:
>  			ddrc_phy_fetch_streaming_message(phy);
>  			break;
>  		case PMC_TRAIN_SUCCESS:
> -			putc_ll('P');
> -			putc_ll('\r');
> -			putc_ll('\n');
>  			return;
>  		case PMC_TRAIN_FAIL:
> -			putc_ll('F');
>  			hang();
>  		}
> -
> -		putc_ll('\r');
> -		putc_ll('\n');
>  	}
>  }

Acked-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>

- rcz


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox