Re: [PATCH 2/2] sandbox: add cpuinfo command

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Sascha,

On 18.10.24 11:06, Sascha Hauer wrote:
> On Wed, Oct 16, 2024 at 11:32:40AM +0200, Yann Sionneau wrote:
>> Hi Ahmad,
>>
>> On 16/10/2024 10:55, Ahmad Fatoum wrote:
>>> We have stack dump support in sandbox via AddressSanitizer, if it's
>>> compiled in. To make it easier to test proper operation, let's a cpuinfo
>> Small typo in the commit msg
>>> command like we already do on ARM and give it the same -s option.
>>>
>>> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
>>> ---
>>>
>>> +BAREBOX_CMD_START(cpuinfo)
>>> +	.cmd            = do_cpuinfo,
>>> +	BAREBOX_CMD_DESC("show info about CPU")
>>> +	BAREBOX_CMD_OPTS("[-s]")
>>
>> It seems the -s option here is mandatory, maybe remove the [ ] brackets? Not sure if it means "optional" here...
> 
> The ARM cpuinfo command shows information about the CPU when called
> without options, so on ARM -s is really optional and I think Ahmad
> wanted the same behaviour here. It's a bit unfortunate that the sandbox
> command doesn't have any information to show when called without
> options.

I can output host system uname -a output in the argumentless case.
I will prepare a v2 in a few days.

Cheers,
Ahmad

> 
> Sascha
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |