From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 19 May 2026 17:42:08 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wPMa8-001Xes-0N for lore@lore.pengutronix.de; Tue, 19 May 2026 17:42:08 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wPMa7-0005Lv-D1 for lore@pengutronix.de; Tue, 19 May 2026 17:42:08 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5QLSySEkqHxN4eA8cvD6JthBUzIRRJFap0JO/85y73k=; b=rLxfUiBr3L7DFLzu1eELDU1Ikp KFA6h91+fj8NC8vM0nX58pvFr2+mPCjrd5sdJgTCwS8OeEEmyFURvcmUHbVpfaevrxiPzFZAP83Pz ANku55LrZ80a8LbphQDoWf+QoO6AtLfc9U5BwCztGLD2pqRQQyIW2PeaWFcEi13uICtIjAgtxYg+J 3LCVYIQR02oz7yl4FLv0woMygRCEimViIOGoXrop8RotvnhyBwonBjrVgO+HkaLhSEFYObD8E3AZZ CUlBBAIIKFgoQLJceqPOrzxiKM+7fxNyGeVPyRzmdZv+Ni3U4szxjPvdVTDz8/xpYgeDJ6gGBo4gV Jgva7J7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPLP3-00000001pE4-3C8w; Tue, 19 May 2026 14:26:37 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wPLOw-00000001pCf-3wkf for barebox@lists.infradead.org; Tue, 19 May 2026 14:26:36 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wPLOv-0004OU-AC; Tue, 19 May 2026 16:26:29 +0200 Message-ID: Date: Tue, 19 May 2026 16:26:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sascha Hauer , Barebox List Cc: Sascha Hauer References: <20260519141502.1427529-1-s.hauer@pengutronix.de> <20260519141502.1427529-2-s.hauer@pengutronix.de> From: Ahmad Fatoum Content-Language: en-US, de-DE, de-BE In-Reply-To: <20260519141502.1427529-2-s.hauer@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260519_072630_983636_0ADDACAE X-CRM114-Status: GOOD ( 24.85 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.2 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH 2/2] mci: sdhci: drop unused re-tuning timer plumbing X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 5/19/26 4:15 PM, Sascha Hauer wrote: > From: Sascha Hauer > > tuning_count and tuning_mode are populated from the host's > CAPABILITIES_1 register at probe time but never consumed. In Linux > they feed an automatic re-tuning timer that periodically re-runs > tuning every N seconds after the controller's re-tuning timer (mode 1) > expires. barebox is a bootloader - tuning runs once at probe and the > controller is then handed to the OS - so the timer infrastructure > doesn't exist and the fields are dead weight. > > Drop: > - tuning_count / tuning_mode struct members > - SDHCI_TUNING_MODE_1/2/3 defines > - SDHCI_RETUNING_TIMER_COUNT_MASK / SDHCI_RETUNING_MODE_MASK > - the dead read into a local tuning_count in sdhci_execute_tuning() > - the populate block in sdhci_setup_host() > > No behavioural change. > > Assisted-By: Claude Opus 4.7 > Signed-off-by: Sascha Hauer Reviewed-by: Ahmad Fatoum > --- > drivers/mci/sdhci.c | 18 ------------------ > drivers/mci/sdhci.h | 7 ------- > 2 files changed, 25 deletions(-) > > diff --git a/drivers/mci/sdhci.c b/drivers/mci/sdhci.c > index 1b13df8583..861e5c7862 100644 > --- a/drivers/mci/sdhci.c > +++ b/drivers/mci/sdhci.c > @@ -311,10 +311,6 @@ int sdhci_execute_tuning(struct sdhci *sdhci, u32 opcode) > { > struct mci_host *host = sdhci->mci; > int err = 0; > - unsigned int tuning_count = 0; > - > - if (sdhci->tuning_mode == SDHCI_TUNING_MODE_1) > - tuning_count = sdhci->tuning_count; > > /* > * The Host Controller needs tuning in case of SDR104 and DDR50 > @@ -1197,19 +1193,5 @@ int sdhci_setup_host(struct sdhci *host) > host->tuning_delay = -1; > host->tuning_loop_count = MAX_TUNING_LOOP; > > - /* Initial value for re-tuning timer count */ > - host->tuning_count = FIELD_GET(SDHCI_RETUNING_TIMER_COUNT_MASK, > - host->caps1); > - > - /* > - * In case Re-tuning Timer is not disabled, the actual value of > - * re-tuning timer will be 2 ^ (n - 1). > - */ > - if (host->tuning_count) > - host->tuning_count = 1 << (host->tuning_count - 1); > - > - /* Re-tuning mode supported by the Host Controller */ > - host->tuning_mode = FIELD_GET(SDHCI_RETUNING_MODE_MASK, host->caps1); > - > return 0; > } > diff --git a/drivers/mci/sdhci.h b/drivers/mci/sdhci.h > index 4a326f9d84..3c678d7999 100644 > --- a/drivers/mci/sdhci.h > +++ b/drivers/mci/sdhci.h > @@ -175,9 +175,7 @@ > #define SDHCI_DRIVER_TYPE_A 0x00000010 > #define SDHCI_DRIVER_TYPE_C 0x00000020 > #define SDHCI_DRIVER_TYPE_D 0x00000040 > -#define SDHCI_RETUNING_TIMER_COUNT_MASK GENMASK(11, 8) > #define SDHCI_USE_SDR50_TUNING 0x00002000 > -#define SDHCI_RETUNING_MODE_MASK GENMASK(15, 14) > #define SDHCI_CLOCK_MUL_MASK GENMASK(23, 16) > #define SDHCI_CAN_DO_ADMA3 0x08000000 > #define SDHCI_SUPPORT_HS400 0x80000000 /* Non-standard */ > @@ -278,11 +276,6 @@ struct sdhci { > bool read_caps; /* Capability flags have been read */ > u32 sdma_boundary; > > - unsigned int tuning_count; /* Timer count for re-tuning */ > - unsigned int tuning_mode; /* Re-tuning mode supported by host */ > -#define SDHCI_TUNING_MODE_1 0 > -#define SDHCI_TUNING_MODE_2 1 > -#define SDHCI_TUNING_MODE_3 2 > /* Delay (ms) between tuning commands */ > int tuning_delay; > int tuning_loop_count; -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |