From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
Barebox List <barebox@lists.infradead.org>
Subject: Re: [PATCH v2 24/34] ARM: mmu: drop ttb argument
Date: Wed, 17 May 2023 15:23:12 +0200 [thread overview]
Message-ID: <cc807833-9ab0-ae79-c6c5-928ae379ebaf@pengutronix.de> (raw)
In-Reply-To: <20230517090340.3954615-25-s.hauer@pengutronix.de>
On 17.05.23 11:03, Sascha Hauer wrote:
> No need to pass ttb to the MMU code, the MMU code can itself call
> arm_mem_ttb() to get the desired base.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> arch/arm/cpu/mmu_32.c | 9 +++++----
> arch/arm/cpu/mmu_64.c | 8 +++++---
> arch/arm/cpu/start.c | 11 +++--------
> arch/arm/cpu/uncompress.c | 7 ++-----
> arch/arm/include/asm/mmu.h | 3 +--
> 5 files changed, 16 insertions(+), 22 deletions(-)
>
> diff --git a/arch/arm/cpu/mmu_32.c b/arch/arm/cpu/mmu_32.c
> index a82382ad1e..bef4a01670 100644
> --- a/arch/arm/cpu/mmu_32.c
> +++ b/arch/arm/cpu/mmu_32.c
> @@ -533,10 +533,11 @@ static inline void map_region(unsigned long start, unsigned long size,
> create_sections(ttb, start, start + size - 1, flags);
> }
>
> -void mmu_early_enable(unsigned long membase, unsigned long memsize,
> - unsigned long _ttb)
> +void mmu_early_enable(unsigned long membase, unsigned long memsize)
> {
> - ttb = (uint32_t *)_ttb;
> + ttb = (uint32_t *)arm_mem_ttb(membase, membase + memsize);
This commit breaks bisection, because v2 changes arm_mem_ttb prototype.
> + pr_debug("enabling MMU, ttb @ 0x%p\n", ttb);
>
> set_ttbr(ttb);
>
> @@ -566,7 +567,7 @@ void mmu_early_enable(unsigned long membase, unsigned long memsize,
> map_region((unsigned long)_stext, _etext - _stext, PMD_SECT_DEF_UNCACHED);
>
> /* maps main memory as cachable */
> - map_region(membase, memsize, PMD_SECT_DEF_CACHED);
> + map_region(membase, memsize - OPTEE_SIZE, PMD_SECT_DEF_CACHED);
(y)
>
> __mmu_cache_on();
> }
> diff --git a/arch/arm/cpu/mmu_64.c b/arch/arm/cpu/mmu_64.c
> index 3cc5b14a46..d32eecf144 100644
> --- a/arch/arm/cpu/mmu_64.c
> +++ b/arch/arm/cpu/mmu_64.c
> @@ -292,10 +292,12 @@ static void early_create_sections(void *ttb, uint64_t virt, uint64_t phys,
>
> #define EARLY_BITS_PER_VA 39
>
> -void mmu_early_enable(unsigned long membase, unsigned long memsize,
> - unsigned long ttb)
> +void mmu_early_enable(unsigned long membase, unsigned long memsize)
> {
> int el;
> + unsigned long ttb = arm_mem_ttb(membase + memsize);
> +
> + pr_debug("enabling MMU, ttb @ 0x%08lx\n", ttb);
>
> /*
> * For the early code we only create level 1 pagetables which only
> @@ -311,7 +313,7 @@ void mmu_early_enable(unsigned long membase, unsigned long memsize,
> set_ttbr_tcr_mair(el, ttb, calc_tcr(el, EARLY_BITS_PER_VA), MEMORY_ATTRIBUTES);
> early_create_sections((void *)ttb, 0, 0, 1UL << (EARLY_BITS_PER_VA - 1),
> attrs_uncached_mem());
> - early_create_sections((void *)ttb, membase, membase, memsize, CACHED_MEM);
> + early_create_sections((void *)ttb, membase, membase, memsize - OPTEE_SIZE, CACHED_MEM);
> tlb_invalidate();
> isb();
> set_cr(get_cr() | CR_M);
> diff --git a/arch/arm/cpu/start.c b/arch/arm/cpu/start.c
> index 87207822a0..165d2d94e6 100644
> --- a/arch/arm/cpu/start.c
> +++ b/arch/arm/cpu/start.c
> @@ -216,14 +216,9 @@ __noreturn __no_sanitize_address void barebox_non_pbl_start(unsigned long membas
>
> mem_malloc_init((void *)malloc_start, (void *)malloc_end - 1);
>
> - if (IS_ENABLED(CONFIG_MMU_EARLY)) {
> - unsigned long ttb = arm_mem_ttb(endmem);
> -
> - if (!IS_ENABLED(CONFIG_PBL_IMAGE)) {
> - pr_debug("enabling MMU, ttb @ 0x%08lx\n", ttb);
> - arm_early_mmu_cache_invalidate();
> - mmu_early_enable(membase, memsize - OPTEE_SIZE, ttb);
> - }
> + if (IS_ENABLED(CONFIG_MMU_EARLY) && !IS_ENABLED(CONFIG_PBL_IMAGE)) {
> + arm_early_mmu_cache_invalidate();
> + mmu_early_enable(membase, memsize);
> }
>
> if (IS_ENABLED(CONFIG_BOOTM_OPTEE))
> diff --git a/arch/arm/cpu/uncompress.c b/arch/arm/cpu/uncompress.c
> index abaf36b68c..e471dd87f9 100644
> --- a/arch/arm/cpu/uncompress.c
> +++ b/arch/arm/cpu/uncompress.c
> @@ -81,11 +81,8 @@ void __noreturn barebox_pbl_start(unsigned long membase, unsigned long memsize,
>
> pr_debug("memory at 0x%08lx, size 0x%08lx\n", membase, memsize);
>
> - if (IS_ENABLED(CONFIG_MMU_EARLY)) {
> - unsigned long ttb = arm_mem_ttb(endmem);
> - pr_debug("enabling MMU, ttb @ 0x%08lx\n", ttb);
> - mmu_early_enable(membase, memsize - OPTEE_SIZE, ttb);
> - }
> + if (IS_ENABLED(CONFIG_MMU_EARLY))
> + mmu_early_enable(membase, memsize);
>
> free_mem_ptr = arm_mem_early_malloc(endmem);
> free_mem_end_ptr = arm_mem_early_malloc_end(endmem);
> diff --git a/arch/arm/include/asm/mmu.h b/arch/arm/include/asm/mmu.h
> index fd8e93f7a3..9d2fdcf365 100644
> --- a/arch/arm/include/asm/mmu.h
> +++ b/arch/arm/include/asm/mmu.h
> @@ -56,8 +56,7 @@ void __dma_clean_range(unsigned long, unsigned long);
> void __dma_flush_range(unsigned long, unsigned long);
> void __dma_inv_range(unsigned long, unsigned long);
>
> -void mmu_early_enable(unsigned long membase, unsigned long memsize,
> - unsigned long ttb);
> +void mmu_early_enable(unsigned long membase, unsigned long memsize);
> void mmu_early_disable(void);
>
> #endif /* __ASM_MMU_H */
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-05-17 13:25 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 9:03 [PATCH v2 00/34] ARM: MMU rework Sascha Hauer
2023-05-17 9:03 ` [PATCH v2 01/34] ARM: remove unused membase argument Sascha Hauer
2023-05-17 12:45 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 02/34] ARM: remove unused define Sascha Hauer
2023-05-17 12:45 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 03/34] ARM: rename __arm_mem_scratch to arm_mem_scratch Sascha Hauer
2023-05-17 12:46 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 04/34] ARM: put scratch mem area below OP-TEE Sascha Hauer
2023-05-17 12:48 ` Ahmad Fatoum
2023-05-17 13:14 ` Sascha Hauer
2023-05-17 15:50 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 05/34] ARM: add arm_mem_optee() Sascha Hauer
2023-05-17 12:53 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 06/34] ARM: make arm_mem_scratch() a static inline function Sascha Hauer
2023-05-17 12:53 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 07/34] ARM: define stack base consistently Sascha Hauer
2023-05-17 12:55 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 08/34] ARM: move arm_mem_scratch_get() lower for consistency Sascha Hauer
2023-05-17 12:57 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 09/34] ARM: drop cache function initialization Sascha Hauer
2023-05-17 9:03 ` [PATCH v2 10/34] ARM: Add _32 suffix to aarch32 specific filenames Sascha Hauer
2023-05-17 9:03 ` [PATCH v2 11/34] ARM: cpu.c: remove unused include Sascha Hauer
2023-05-17 9:03 ` [PATCH v2 12/34] ARM: mmu-common.c: use common mmu include Sascha Hauer
2023-05-17 9:03 ` [PATCH v2 13/34] ARM: mmu32: rename mmu.h to mmu_32.h Sascha Hauer
2023-05-17 9:03 ` [PATCH v2 14/34] ARM: mmu: implement MAP_FAULT Sascha Hauer
2023-05-17 9:03 ` [PATCH v2 15/34] ARM: mmu64: Use arch_remap_range where possible Sascha Hauer
2023-05-17 9:03 ` [PATCH v2 16/34] ARM: mmu32: implement zero_page_*() Sascha Hauer
2023-05-17 9:03 ` [PATCH v2 17/34] ARM: i.MX: Drop HAB workaround Sascha Hauer
2023-05-17 13:01 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 18/34] ARM: Move early MMU after malloc initialization Sascha Hauer
2023-05-17 9:03 ` [PATCH v2 19/34] ARM: mmu: move dma_sync_single_for_device to extra file Sascha Hauer
2023-05-17 9:03 ` [PATCH v2 20/34] ARM: mmu: merge mmu-early_xx.c into mmu_xx.c Sascha Hauer
2023-05-17 9:03 ` [PATCH v2 21/34] ARM: mmu: alloc 64k for early page tables Sascha Hauer
2023-05-17 13:03 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 22/34] ARM: mmu32: create alloc_pte() Sascha Hauer
2023-05-17 13:07 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 23/34] ARM: mmu64: " Sascha Hauer
2023-05-17 13:15 ` Ahmad Fatoum
2023-05-17 13:17 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 24/34] ARM: mmu: drop ttb argument Sascha Hauer
2023-05-17 13:23 ` Ahmad Fatoum [this message]
2023-05-17 9:03 ` [PATCH v2 25/34] ARM: mmu: always do MMU initialization early when MMU is enabled Sascha Hauer
2023-05-17 13:29 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 26/34] ARM: mmu32: Assume MMU is on Sascha Hauer
2023-05-17 13:36 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 27/34] ARM: mmu32: Fix pmd_flags_to_pte() for ARMv4/5/6 Sascha Hauer
2023-05-17 13:39 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 28/34] ARM: mmu32: Add pte_flags_to_pmd() Sascha Hauer
2023-05-17 13:43 ` Ahmad Fatoum
2023-05-17 14:44 ` Sascha Hauer
2023-05-17 9:03 ` [PATCH v2 29/34] ARM: mmu32: add get_pte_flags, get_pmd_flags Sascha Hauer
2023-05-17 13:46 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 30/34] ARM: mmu32: move functions into c file Sascha Hauer
2023-05-17 13:48 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 31/34] ARM: mmu32: read TTB value from register Sascha Hauer
2023-05-17 13:58 ` Ahmad Fatoum
2023-05-17 14:39 ` Sascha Hauer
2023-05-19 6:53 ` Ahmad Fatoum
2023-05-19 7:44 ` Sascha Hauer
2023-05-19 7:52 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 32/34] ARM: mmu32: Use pages for early MMU setup Sascha Hauer
2023-05-17 14:21 ` Ahmad Fatoum
2023-05-22 8:14 ` Sascha Hauer
2023-05-17 9:03 ` [PATCH v2 33/34] ARM: mmu32: Skip reserved ranges during initialization Sascha Hauer
2023-05-17 14:43 ` Ahmad Fatoum
2023-05-17 14:55 ` Sascha Hauer
2023-05-17 15:56 ` Ahmad Fatoum
2023-05-17 9:03 ` [PATCH v2 34/34] ARM: mmu64: Use two level pagetables in early code Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc807833-9ab0-ae79-c6c5-928ae379ebaf@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox