From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFZDp-0004Hw-5w for barebox@lists.infradead.org; Wed, 02 Oct 2019 07:38:54 +0000 Message-ID: From: Rouven Czerwinski Date: Wed, 02 Oct 2019 09:38:48 +0200 In-Reply-To: <20191001090939.11941-1-a.fatoum@pengutronix.de> References: <20191001090939.11941-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH 1/2] ARM: cache_64: invalidate icache in arm_early_mmu_cache_flush To: Ahmad Fatoum , barebox@lists.infradead.org Cc: andrew.smirnov@gmail.com, lst@pengutronix.de Hello Ahmad, with these two patches applied, the NXP i.MX8MQ no longer starts into barebox. - rcz On Tue, 2019-10-01 at 11:09 +0200, Ahmad Fatoum wrote: > So far arm_early_mmu_cache_flush has only been used in preparation > for > executing newly-written code. For this reason, on ARMv7 and below, > it had always invalidate the icache after the dcache flush. > We don't do this on ARM64, but sync_caches_for_execution depends on > this, > which had this comment that didn't hold true for ARM64: > > > Despite the name arm_early_mmu_cache_flush not only flushes the > > data cache, but also invalidates the instruction cache. > > It might be worthwhile to decouple dcache flushing from icache > invalidation, but for now, align what we do on ARM64 with what we do > for > 32-bit ARMs. > > This fixes a potential read of stale instructions when loading > second-stage barebox from the PBL with MMU disabled. > > Signed-off-by: Ahmad Fatoum > --- > arch/arm/cpu/cache_64.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/cpu/cache_64.c b/arch/arm/cpu/cache_64.c > index 45f01e8dc9cf..847323525424 100644 > --- a/arch/arm/cpu/cache_64.c > +++ b/arch/arm/cpu/cache_64.c > @@ -27,6 +27,7 @@ int arm_set_cache_functions(void) > void arm_early_mmu_cache_flush(void) > { > v8_flush_dcache_all(); > + v8_invalidate_icache_all(); > } > > void arm_early_mmu_cache_invalidate(void) _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox