SAMA5D3-xplained board cleanup question

SAMA5D3-xplained board cleanup question

[Alexander Shiyan]

Hello All!

 I would like to propose a cleanup for the SAMA5D3-xplained board support.
The board currently has code in board.c that configures the
at91sam9-smc (Static Memory Controller).
However, since the board uses devicetree, this configuration should be
handled by the MFD driver
that is responsible for the SMC and is devicetree-based.

Therefore, I think we can remove the SMC configuration from the board file.
But I don't have a SAMA5D3-xplained board to test this change.

Could someone who has access to this board please test the removal of
the SMC configuration?

Thanks!

Re: SAMA5D3-xplained board cleanup question

[Sascha Hauer]

Hi Alexander,

On Fri, Jun 20, 2025 at 03:21:56PM +0300, Alexander Shiyan wrote:
> Hello All!
> 
>  I would like to propose a cleanup for the SAMA5D3-xplained board support.
> The board currently has code in board.c that configures the
> at91sam9-smc (Static Memory Controller).
> However, since the board uses devicetree, this configuration should be
> handled by the MFD driver
> that is responsible for the SMC and is devicetree-based.
> 
> Therefore, I think we can remove the SMC configuration from the board file.
> But I don't have a SAMA5D3-xplained board to test this change.
> 
> Could someone who has access to this board please test the removal of
> the SMC configuration?

It's rather unlikely that someone gives a positive answer here.
I'd say just send the patch and add a note that it's untested.

That said, we @Pengutronix should have such a board, at least I can find
it in our inventory list. Not sure if I can motivate someone to connect
it for me.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: SAMA5D3-xplained board cleanup question

[Ahmad Fatoum]

Hi,

On 6/23/25 11:31, Sascha Hauer wrote:
> Hi Alexander,
> 
> On Fri, Jun 20, 2025 at 03:21:56PM +0300, Alexander Shiyan wrote:
>> Hello All!
>>
>>  I would like to propose a cleanup for the SAMA5D3-xplained board support.
>> The board currently has code in board.c that configures the
>> at91sam9-smc (Static Memory Controller).
>> However, since the board uses devicetree, this configuration should be
>> handled by the MFD driver
>> that is responsible for the SMC and is devicetree-based.
>>
>> Therefore, I think we can remove the SMC configuration from the board file.
>> But I don't have a SAMA5D3-xplained board to test this change.
>>
>> Could someone who has access to this board please test the removal of
>> the SMC configuration?
> 
> It's rather unlikely that someone gives a positive answer here.
> I'd say just send the patch and add a note that it's untested.
> 
> That said, we @Pengutronix should have such a board, at least I can find
> it in our inventory list. Not sure if I can motivate someone to connect
> it for me.

I have one at home. If you send a patch, I can give it a test.

Cheers,
Ahmad

> 
> Sascha
> 

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

Re: SAMA5D3-xplained board cleanup question

[Alexander Shiyan]

Hello.

I'll do it now. Thanks!

пн, 23 июн. 2025 г. в 13:16, Ahmad Fatoum <a.fatoum@pengutronix.de>:
>
> Hi,
>
> On 6/23/25 11:31, Sascha Hauer wrote:
> > Hi Alexander,
> >
> > On Fri, Jun 20, 2025 at 03:21:56PM +0300, Alexander Shiyan wrote:
> >> Hello All!
> >>
> >>  I would like to propose a cleanup for the SAMA5D3-xplained board support.
> >> The board currently has code in board.c that configures the
> >> at91sam9-smc (Static Memory Controller).
> >> However, since the board uses devicetree, this configuration should be
> >> handled by the MFD driver
> >> that is responsible for the SMC and is devicetree-based.
> >>
> >> Therefore, I think we can remove the SMC configuration from the board file.
> >> But I don't have a SAMA5D3-xplained board to test this change.
> >>
> >> Could someone who has access to this board please test the removal of
> >> the SMC configuration?
> >
> > It's rather unlikely that someone gives a positive answer here.
> > I'd say just send the patch and add a note that it's untested.
> >
> > That said, we @Pengutronix should have such a board, at least I can find
> > it in our inventory list. Not sure if I can motivate someone to connect
> > it for me.
>
> I have one at home. If you send a patch, I can give it a test.
>
> Cheers,
> Ahmad
>
> >
> > Sascha
> >
>
> --
> Pengutronix e.K.                  |                             |
> Steuerwalder Str. 21              | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |
>