From: Peter Kardos <kardos.peter.sk@gmail.com>
To: barebox@lists.infradead.org
Subject: Re: [PATCH v2] ARM: vector_table: Fix creation of second level page table
Date: Thu, 25 Aug 2016 23:32:43 +0200 [thread overview]
Message-ID: <d3c2af19-1d8f-a078-ef33-3cc43a14d990@gmail.com> (raw)
In-Reply-To: <1472106992-30755-1-git-send-email-s.hauer@pengutronix.de>
Tested this one as well with my AT91RM9200 system, v2016.08 + patch;
The system starts/boots as expected.
If no one objects, we can consider this issue closed/fixed.
Peter
On 8/25/2016 8:36 AM, Sascha Hauer wrote:
> The second level page tables can only start at a 1MiB section boundary,
> so instead of calling arm_create_pte() with the high vector address
> (which is 0xffff0000, not 1MiB aligned) we have to call it with
> 0xfff00000 to correctly create a second level page table.
> The old values broke SoCs which have peripherals in the upper 1MiB
> area, like for example the Atmel AT91RM9200. On these Socs we correctly
> created the vector page, but the pages around it did not have a 1:1
> mapping anymore which led to unreachable peripherals.
>
> Fixes: f6b77fe9: ARM: Rework vector table setup
>
> Reported-by: Peter Kardos <kardos.peter.sk@gmail.com>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>
> Changes since v1:
> - Use ALIGN_DOWN instead of open coded alignment
> - more clear commit message
>
> arch/arm/cpu/mmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/cpu/mmu.c b/arch/arm/cpu/mmu.c
> index a31bce4..459abe5 100644
> --- a/arch/arm/cpu/mmu.c
> +++ b/arch/arm/cpu/mmu.c
> @@ -307,7 +307,7 @@ static void create_vector_table(unsigned long adr)
> vectors = xmemalign(PAGE_SIZE, PAGE_SIZE);
> pr_debug("Creating vector table, virt = 0x%p, phys = 0x%08lx\n",
> vectors, adr);
> - exc = arm_create_pte(adr);
> + exc = arm_create_pte(ALIGN_DOWN(adr, SZ_1M));
> idx = (adr & (SZ_1M - 1)) >> PAGE_SHIFT;
> exc[idx] = (u32)vectors | PTE_TYPE_SMALL | pte_flags_cached;
> }
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-08-25 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 6:36 Sascha Hauer
2016-08-25 21:32 ` Peter Kardos [this message]
2016-08-26 5:45 ` Sascha Hauer
2016-08-27 19:09 ` Peter Kardos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3c2af19-1d8f-a078-ef33-3cc43a14d990@gmail.com \
--to=kardos.peter.sk@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox