Re: [PATCH 2/2] bootm: create generic FIT image handler

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hi Sascha,

On 07.04.25 15:07, Sascha Hauer wrote:
> -static struct image_handler arm_fit_handler = {
> -        .name = "FIT image",
> -        .bootm = do_bootm_linux,
> -        .filetype = filetype_oftree,
> -};
> -

You delete the object, but not the references to it from the initcall.


> -static __maybe_unused int sandbox_fit_register(void)
> +static int sandbox_fit_register(void)
>  {
> -	return register_image_handler(&sandbox_fit_handler);
> +	return register_image_handler(&fit_handler);
>  }
> -#ifdef CONFIG_SANDBOX
>  late_initcall(sandbox_fit_register);

Initcall needs to be renamed.

> -#endif


Cheers,
Ahmad


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |