From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 07 Nov 2022 14:06:36 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1os1pk-000Qxe-Rc for lore@lore.pengutronix.de; Mon, 07 Nov 2022 14:06:36 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1os1pj-0005En-Kw for lore@pengutronix.de; Mon, 07 Nov 2022 14:06:36 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Content-Type:References:In-Reply-To:Date:To:From:Subject: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sYHmJSXeRqWPjd4aPFuwrBcgMkTHi3zwlVCNIbUcbyM=; b=KEb7liSq0GdTvPpnhXdiqjsUaY tLV1NL26jtTOgupAI8eeZ9dfqK5kkC8XQlldzT/hgFcesDjbxamfWJ23EoLFKFi7TqU8qbWWaFowM uurhqde0fTsrwjfR0yWFV81yD8H0CAFGtB5yok2dP3c15fflx38knT/Wgn8cbDcmpuSOnUymZ0lJK fKFZnPIILy4g9APy4KL+CB+sr4c/JNEZkaxEt/YhZyMqWj11y0hiViVR5lsjhyp/vEDElknZGq5XJ OPmyIouZXuC35yruTBmZkqj15CI9d9/qxr2L7EPWE69/70q7T8e/0ACa6bnjAZUcXE2cknbQnqs9J /iQP1o+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1os1oR-00EfEo-Og; Mon, 07 Nov 2022 13:05:15 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1os1oL-00EfB1-BN for barebox@lists.infradead.org; Mon, 07 Nov 2022 13:05:10 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=irc.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1os1oK-0004iL-0S for barebox@lists.infradead.org; Mon, 07 Nov 2022 14:05:08 +0100 Message-ID: From: Johannes Zink To: barebox@lists.infradead.org Date: Mon, 07 Nov 2022 14:05:06 +0100 In-Reply-To: <20221107111701.2570303-6-o.rempel@pengutronix.de> References: <20221107111701.2570303-1-o.rempel@pengutronix.de> <20221107111701.2570303-6-o.rempel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221107_050509_408142_8817FB1C X-CRM114-Status: GOOD ( 21.75 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-4.5 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH v3 6/8] net: dsa: fix of_device_ensure_probed*() for switch ports X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.ext.pengutronix.de) Hi Oleksij, On Mon, 2022-11-07 at 12:16 +0100, Oleksij Rempel wrote: > Crete ports by using of_platform_device_create() in the same way as another nitpick: s/Crete/Create/ Best regards Johannes > it > is used by of_device_ensure_probed*(). Otherwise we are creating > multiple devices for the same node. > > At same time we need to link dummy driver to make this logic work. > > Signed-off-by: Oleksij Rempel > --- >  drivers/net/dsa.c | 18 +++++------------- >  include/dsa.h     |  2 +- >  2 files changed, 6 insertions(+), 14 deletions(-) > > diff --git a/drivers/net/dsa.c b/drivers/net/dsa.c > index 124059ee3c..bc33892f39 100644 > --- a/drivers/net/dsa.c > +++ b/drivers/net/dsa.c > @@ -59,7 +59,7 @@ static int dsa_port_probe(struct eth_device *edev) >         int ret; >   >         if (ops->port_probe) { > -               interface = of_get_phy_mode(dp->dev.device_node); > +               interface = of_get_phy_mode(dp->dev->device_node); >                 ret = ops->port_probe(dp, dp->index, interface); >                 if (ret) >                         return ret; > @@ -93,7 +93,7 @@ static int dsa_port_start(struct eth_device *edev) >         if (dp->enabled) >                 return -EBUSY; >   > -       interface = of_get_phy_mode(dp->dev.device_node); > +       interface = of_get_phy_mode(dp->dev->device_node); >   >         if (ops->port_pre_enable) { >                 /* In case of RMII interface we need to enable RMII > clock > @@ -241,21 +241,13 @@ static int dsa_switch_register_edev(struct > dsa_switch *ds, >         struct eth_device *edev; >         struct device_d *dev; >         struct dsa_port *dp; > -       int ret; >   >         ds->dp[port] = xzalloc(sizeof(*dp)); > - >         dp = ds->dp[port]; > -       dev = &dp->dev; > - > -       dev_set_name(dev, "dsa_port"); > -       dev->id = DEVICE_ID_DYNAMIC; > -       dev->parent = ds->dev; > -       dev->device_node = dn; >   > -       ret = register_device(dev); > -       if (ret) > -               return ret; > +       dev = of_platform_device_create(dn, ds->dev); > +       of_platform_device_dummy_drv(dev); > +       dp->dev = dev; >   >         dp->rx_buf = xmalloc(DSA_PKTSIZE); >         dp->ds = ds; > diff --git a/include/dsa.h b/include/dsa.h > index 75a939f2cb..f428aa74a5 100644 > --- a/include/dsa.h > +++ b/include/dsa.h > @@ -58,7 +58,7 @@ struct dsa_ops { >  }; >   >  struct dsa_port { > -       struct device_d dev; > +       struct device_d *dev; >         struct dsa_switch *ds; >         unsigned int index; >         struct eth_device edev; -- Pengutronix e.K. | Johannes Zink | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |