mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] scripts: include: rename printk.h to printf.h
@ 2025-02-05 10:25 Jules Maselbas
  2025-02-07  8:27 ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: Jules Maselbas @ 2025-02-05 10:25 UTC (permalink / raw)
  To: barebox; +Cc: Jules Maselbas

The include scripts/include/asm-generic/bug.h relied on a printk.h
compatible header which is located in the scripts/include/ and was
not updated when printk.h was renamed to printf.h.

Fixes: d8ea946bcf ("include: rename printk.h to printf.h")
Signed-off-by: Jules Maselbas <jmaselbas@zdiv.net>
---
 scripts/include/{printk.h => printf.h} | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
 rename scripts/include/{printk.h => printf.h} (54%)

diff --git a/scripts/include/printk.h b/scripts/include/printf.h
similarity index 54%
rename from scripts/include/printk.h
rename to scripts/include/printf.h
index 363d32f2e5..2ce99c2fa8 100644
--- a/scripts/include/printk.h
+++ b/scripts/include/printf.h
@@ -1,9 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
-#ifndef __PRINTK_H
-#define __PRINTK_H
+#ifndef __PRINTF_H
+#define __PRINTF_H
 
 #include <stdio.h>
 
-#define printk printf
-
 #endif
-- 
2.48.1




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scripts: include: rename printk.h to printf.h
  2025-02-05 10:25 [PATCH] scripts: include: rename printk.h to printf.h Jules Maselbas
@ 2025-02-07  8:27 ` Sascha Hauer
  2025-02-20  6:38   ` Ahmad Fatoum
  0 siblings, 1 reply; 4+ messages in thread
From: Sascha Hauer @ 2025-02-07  8:27 UTC (permalink / raw)
  To: barebox, Jules Maselbas


On Wed, 05 Feb 2025 11:25:49 +0100, Jules Maselbas wrote:
> The include scripts/include/asm-generic/bug.h relied on a printk.h
> compatible header which is located in the scripts/include/ and was
> not updated when printk.h was renamed to printf.h.
> 
> 

Applied, thanks!

[1/1] scripts: include: rename printk.h to printf.h
      https://git.pengutronix.de/cgit/barebox/commit/?id=f7a4435177aa (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scripts: include: rename printk.h to printf.h
  2025-02-07  8:27 ` Sascha Hauer
@ 2025-02-20  6:38   ` Ahmad Fatoum
  2025-02-21 13:22     ` Sascha Hauer
  0 siblings, 1 reply; 4+ messages in thread
From: Ahmad Fatoum @ 2025-02-20  6:38 UTC (permalink / raw)
  To: Sascha Hauer, barebox, Jules Maselbas; +Cc: Enrico Joerns

Hello Sascha,

On 07.02.25 09:27, Sascha Hauer wrote:
> 
> On Wed, 05 Feb 2025 11:25:49 +0100, Jules Maselbas wrote:
>> The include scripts/include/asm-generic/bug.h relied on a printk.h
>> compatible header which is located in the scripts/include/ and was
>> not updated when printk.h was renamed to printf.h.
>>
>>
> 
> Applied, thanks!

Please apply this patch to master as the musl build is otherwise broken
(glibc provides a <printf.h> header).

Thanks,
Ahmad

> 
> [1/1] scripts: include: rename printk.h to printf.h
>       https://git.pengutronix.de/cgit/barebox/commit/?id=f7a4435177aa (link may not be stable)
> 
> Best regards,


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scripts: include: rename printk.h to printf.h
  2025-02-20  6:38   ` Ahmad Fatoum
@ 2025-02-21 13:22     ` Sascha Hauer
  0 siblings, 0 replies; 4+ messages in thread
From: Sascha Hauer @ 2025-02-21 13:22 UTC (permalink / raw)
  To: Ahmad Fatoum; +Cc: barebox, Jules Maselbas, Enrico Joerns

On Thu, Feb 20, 2025 at 07:38:47AM +0100, Ahmad Fatoum wrote:
> Hello Sascha,
> 
> On 07.02.25 09:27, Sascha Hauer wrote:
> > 
> > On Wed, 05 Feb 2025 11:25:49 +0100, Jules Maselbas wrote:
> >> The include scripts/include/asm-generic/bug.h relied on a printk.h
> >> compatible header which is located in the scripts/include/ and was
> >> not updated when printk.h was renamed to printf.h.
> >>
> >>
> > 
> > Applied, thanks!
> 
> Please apply this patch to master as the musl build is otherwise broken
> (glibc provides a <printf.h> header).

Did that

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-02-21 13:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-05 10:25 [PATCH] scripts: include: rename printk.h to printf.h Jules Maselbas
2025-02-07  8:27 ` Sascha Hauer
2025-02-20  6:38   ` Ahmad Fatoum
2025-02-21 13:22     ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox