From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 14 Oct 2024 17:38:23 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1t0N9L-004JWA-2C for lore@lore.pengutronix.de; Mon, 14 Oct 2024 17:38:23 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t0N9L-0001eU-2n for lore@pengutronix.de; Mon, 14 Oct 2024 17:38:23 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OzmnRUGSs2akTQTuP4WZ45KLGUIYWLyR0UXVb8TipUU=; b=J9BclIkE3Z03avCCugW3mMx4HW pDeAW/d3D45Ie8U6vI3EpuwFJcNSQtmxqtNuNhiiyTKWpmbI8LfA1R0hAEHHT2hbriAI6HM7NyZay hwIQ3ZUj87tPWcIueEgP7KaLj6Q0ApFpfdD3X5lZOZVVWgMpYQMEHgB50d30zmEk0d3r5rnGKnDOX p71eTnDJcziOGq9Mpwz0hlZtxV0+a1aFYO3Bo+Pe7YGF2rSfYj6MZ5CUaEIMhshbhG7xkfG7VtgVy p/N5qBQsaZsjdrJQwsZpp9Y9Pwtf3dnBa38I7C5uVqAgUKP7VW6U9zhwHJ5oi8vS6JBjZ/b5J8ipL NR3YXOMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t0N8n-00000005i8H-3z5d; Mon, 14 Oct 2024 15:37:49 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t0MYG-00000005aDz-2NFv for barebox@lists.infradead.org; Mon, 14 Oct 2024 15:00:05 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPV6:::1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1t0MYF-0003Ig-8i; Mon, 14 Oct 2024 17:00:03 +0200 Message-ID: Date: Mon, 14 Oct 2024 17:00:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sascha Hauer Cc: barebox@lists.infradead.org, Rashidwi References: <20241002160714.2423842-1-a.fatoum@pengutronix.de> <103a1f5c-5d69-4648-81f4-63ab4e2d427b@pengutronix.de> Content-Language: en-US From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241014_080004_657297_0C814830 X-CRM114-Status: GOOD ( 16.42 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.1 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] uimage: fix CRC32 verification on NFS X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 14.10.24 16:52, Sascha Hauer wrote: > On Mon, Oct 14, 2024 at 03:18:18PM +0200, Ahmad Fatoum wrote: >> On 14.10.24 15:10, Sascha Hauer wrote: >>> On Wed, Oct 02, 2024 at 06:07:15PM +0200, Ahmad Fatoum wrote: >>>> diff --git a/common/uimage.c b/common/uimage.c >>>> index 140a08c1e426..c578edae2606 100644 >>>> --- a/common/uimage.c >>>> +++ b/common/uimage.c >>>> @@ -272,7 +272,9 @@ int uimage_verify(struct uimage_handle *handle) >>>> ret = read(handle->fd, buf, now); >>>> if (ret < 0) >>>> goto err; >>>> - crc = crc32(crc, buf, now); >>>> + if (!ret) >>>> + break; >>> >>> Should we have an extra error message in this case? The information that >>> a uImage is shorter than expected might be valuable for the user. >> >> I don't see the need to differentiate between premature end and corrupted >> bytes. Both are problems in another layer anyway and people still stuck >> using uImage may not like losing extra bytes for an error message anyway. > > I could imagine that knowing that the image is too short would put me on > another path when searching for the issue. > > Anyway, debugging this shouldn't be too hard, even without this > information. Agreed. Cheers, Ahmad > > Sascha > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |