From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hV98O-0006hP-94 for barebox@lists.infradead.org; Mon, 27 May 2019 06:29:27 +0000 References: <20190521155626.9906-1-a.fatoum@pengutronix.de> <20190521155626.9906-2-a.fatoum@pengutronix.de> From: Ahmad Fatoum Message-ID: Date: Mon, 27 May 2019 08:29:18 +0200 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH v2 1/5] clk: imx6: remove quirky clk_set_parent(LDB_diN_sel, pll5_video_div) To: Andrey Smirnov Cc: Barebox List , Raphael Poggi , pza@pengutronix.de Hello Andrey, On 26/5/19 23:55, Andrey Smirnov wrote: > On Tue, May 21, 2019 at 8:56 AM Ahmad Fatoum wrote: >> > This particular patch does break a non 6Q+ version of RDU2, but the > follow up ones in the series fix it, so it seems that no action is > really necessary on my part. The reparenting removed in this patch isn't reinstated by the rest of the series. They merely apply parentage expressed in the device tree in a glitch-free manner. As both barebox and kernel imx6qdl-zii-rdu2.dtsi lack the relevant assigned-clock-parents snippet, I am not sure what it is this patch broke that the follow-up ones fixed? Generally, affected boards have been broken since day 1, because the LVDS output would've locked up every blue moon or so. If this patch breaks them, they're just more reliably broken. :-) Cheers Ahmad > > Thanks, > Andrey Smirnov > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox