Re: [PATCH 02/12] ARM: qemu-virt: add image for use as -bios

[Ahmad Fatoum <a.fatoum@barebox.org>]

Hello Sascha,

On 1/16/26 11:21 AM, Ahmad Fatoum wrote:
> Hi,
> 
> On 1/16/26 09:33, Sascha Hauer wrote:
>> On Thu, Jan 15, 2026 at 12:54:28PM +0100, Ahmad Fatoum wrote:
>>> +	printf("Using %s device tree at %p\n", origin, fdt);
>>
>> Doesn't make a difference for PBL, but I think pr_info would be more
>> appropriate here.
> 
> Sure.
> 
>>>  #define BAREBOX_BOARDDATA_COMPRESSED_DTB_MAGIC 0x7b66bcbd
>>> diff --git a/test/arm/virt-el2@multi_v8_defconfig.yaml b/test/arm/virt-el2@multi_v8_defconfig.yaml
>>> new file mode 100644
>>> index 000000000000..8aa514fb4179
>>> --- /dev/null
>>> +++ b/test/arm/virt-el2@multi_v8_defconfig.yaml
>>
>> You anticipated ARM32 above, how about adding these for
>> multi_v7_defconfig as well?
> 
> Ah, the name is misleading anyway, because it still runs in EL1 (which is good,
> as we can use hvc for PSCI, but I was not aware of that yet when I named the
> file).
> 
> I can rename and add a new v7 YAML in v2.

Are you done reading through the series or should I wait before sending
v2 some more?

Cheers,
Ahmad

> 
> Cheers,
> Ahmad
> 
>>
>> Sascha
>>
> 
> 
>