From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>, barebox@lists.infradead.org
Subject: Re: [PATCH] clocksource: omit seeding of RNG in PBL
Date: Tue, 29 Apr 2025 11:53:07 +0200 [thread overview]
Message-ID: <e6f4523c-6e63-42fe-be22-d15707d2267a@pengutronix.de> (raw)
In-Reply-To: <174555956247.545067.10905121643082274040.b4-ty@pengutronix.de>
Hello Sascha,
On 4/25/25 07:39, Sascha Hauer wrote:
>
> On Thu, 24 Apr 2025 10:48:33 +0200, Ahmad Fatoum wrote:
>> We do not maintain a PRNG in the PBL, so we should omit the call to
>> srand_xor in PBL, otherwise it expands to BUG() and breaks the newly
>> introduced PBL clocksource support.
>>
>>
>
> Applied, thanks!
While the patch is correct, I think it would be better to just drop the
BUG() in the header instead of littering IN_PROPER around.
If the patch isn't pushed yet, can you drop it?
I just sent out an alternative.
Thanks,
Ahmad
>
> [1/1] clocksource: omit seeding of RNG in PBL
> https://git.pengutronix.de/cgit/barebox/commit/?id=a6e031cc425d (link may not be stable)
>
> Best regards,
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-04-29 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 8:48 Ahmad Fatoum
2025-04-25 5:39 ` Sascha Hauer
2025-04-29 9:53 ` Ahmad Fatoum [this message]
2025-04-29 15:03 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6f4523c-6e63-42fe-be22-d15707d2267a@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox