Re: [PATCH 1/7] drivers: bus: Add ti-sysc bus driver

[Teresa Remmet <t.remmet@phytec.de>]

Am Dienstag, den 12.02.2019, 16:56 -0800 schrieb Andrey Smirnov:
> On Tue, Feb 12, 2019 at 5:13 AM Teresa Remmet <t.remmet@phytec.de>
> wrote:
> > 
> > Hello Andrey,
> > 
> > Am Montag, den 11.02.2019, 18:57 -0800 schrieb Andrey Smirnov:
> > > On Mon, Feb 11, 2019 at 7:16 AM Teresa Remmet <t.remmet@phytec.de
> > > >
> > > wrote:
> > > > 
> > > > Adds minimal support for the sysc interconnect target module
> > > > found
> > > > on many TI SoCs. With this device tree includes have been
> > > > rearagned.
> > > > We need the driver to probe the child devices of the bus.
> > > > 
> > > > Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> > > > ---
> > > > 
> > > > +
> > > > +static const struct of_device_id sysc_match_table[] = {
> > > > +       { .compatible = "simple-bus", },
> > > > +       { /* sentinel */ },
> > > > +};
> > > > +
> > > > +static int ti_sysc_probe(struct device_d *dev)
> > > > +{
> > > > +       int ret;
> > > > +
> > > > +       ret = of_platform_populate(dev->device_node,
> > > > sysc_match_table, dev);
> > > 
> > > Is sysc_match_table really necessary? AFAIK that argument can be
> > > NULL
> > > unless on of the child nodes needs to be treated like a platform
> > > bus
> > > as well.
> > 
> > My first attempted was using NULL but this does not work. As for
> > example the pinmux node (pinmux@800) is child of a simple-bus. And
> > the
> > simple-bus itself is a child of a ti-sysc node. See
> > dts/src/arm/am33xx-
> > l4.dtsi.
> > The kernel does it the same way.
> > 
> 
> Ah, I see, your use-case does require child nodes to be treated as a
> platform bus. FWIW, there's also globally visible
> of_default_bus_match_table that can probably replace
> sysc_match_table.

Yes, will add this in v2. 

Thanks,
Teresa


> 
> Thanks,
> Andrey Smirnov


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox