From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 16 Dec 2024 10:37:11 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tN7XK-008ln0-27 for lore@lore.pengutronix.de; Mon, 16 Dec 2024 10:37:11 +0100 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tN7XK-00050h-0U for lore@pengutronix.de; Mon, 16 Dec 2024 10:37:11 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o6Y7YOpEO2cE5zpE4clzF7W9p4EuDAY4XdgM42aslkU=; b=FQXLnvf6scydPpF3U/DnXfHWdo 5tma1ypKb91vOaIbcvrxvkcTCY7UHHuiIT9IZLKlnYPEg8BgwnxPgZavCMRy0V3GKig4bJt1pY0DY cpRk41gLKpaBnJt+xfqc5JJCEr9Y4juZZYIvKOV5epS0rzQheIzyPDbMugtde8i7mo37tuXW/lIav B89MiFi0ZuMqlJS8nEV/8szfZg7SGws5Hk3uaDkRy7RgKRoOIDlx8ZQGDn7LHicOYnsLeazmqhMgK cwbcfcZjCHZcPP5a4m9dOejq0zAqZW/TO7lQMHv0vEdcJcrw5wugyxLFNQWR6iMfoBnzuT31G16EC cpYUVKnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tN7Wv-00000009Yak-2JBc; Mon, 16 Dec 2024 09:36:45 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tN7Wt-00000009YaM-1QrM for barebox@lists.infradead.org; Mon, 16 Dec 2024 09:36:44 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1tN7Ws-0004ud-2k; Mon, 16 Dec 2024 10:36:42 +0100 Message-ID: Date: Mon, 16 Dec 2024 10:36:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sascha Hauer Cc: Jonas Rebmann , BAREBOX References: <20241213-toradex-colibri-imx6-v1-1-afb618cbf25b@pengutronix.de> <452ed951-8693-4742-aa4f-a0df124c9a3b@pengutronix.de> Content-Language: en-US From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241216_013643_384755_294C76DF X-CRM114-Status: GOOD ( 15.37 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.1 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] ARM: boards: Add support for todarex colibri imx6 on iris X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) Hi, On 16.12.24 10:34, Sascha Hauer wrote: > On Mon, Dec 16, 2024 at 09:55:47AM +0100, Ahmad Fatoum wrote: >> On 16.12.24 09:18, Sascha Hauer wrote: >> By using the DCD table, the benefit of the console so early is greatly >> reduced, that's why I told Jonas that DEBUG_LL would be enough. > > Ok. Nevertheless the IS_ENABLED(CONFIG_DEBUG_LL) can be removed. Yes, just once is enough. >>>> + >>>> +ENTRY_FUNCTION(start_imx6s_colibri_iris, r0, r1, r2) >>>> +{ >>>> + void *fdt; >>>> + >>>> + imx6_cpu_lowlevel_init(); >>>> + >>>> + if (IS_ENABLED(CONFIG_DEBUG_LL)) { >>>> + setup_uart(); >>>> + } >>>> + >>>> + fdt = __dtb_z_imx6dl_colibri_iris_start + get_runtime_offset(); >>>> + barebox_arm_entry(0x10000000, SZ_256M, fdt); >>>> +} >>> >>> You should be able to call imx6q_barebox_entry() instead here. This >>> will read the amount of DRAM back from the controller. No need to >>> distinguish between both board anymore and you can merge both images >>> into one. >> >> The images have different DCD tables, so combining the entry point >> won't work. You can't have different imxcfg files for a single entry point. > > Ah, right. Would __alias work for ENTRY_FUNCTION? I don't see why it shouldn't. Jonas can surely give it a try. :-) Cheers, Ahmad > > Sascha > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |