mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Teresa Remmet <T.Remmet@phytec.de>,
	"barebox@lists.infradead.org" <barebox@lists.infradead.org>,
	"lst@pengutronix.de" <lst@pengutronix.de>
Cc: "upstream@phytec.de" <upstream@phytec.de>,
	Joacim Zetterling <joacim.zetterling@westermo.com>
Subject: Re: [PATCH] arm: imx: mmdc_size: Increase row_max for imx8m
Date: Mon, 20 Jun 2022 15:19:34 +0200	[thread overview]
Message-ID: <e8dfb72b-3a12-eef5-13ff-894f60a90159@pengutronix.de> (raw)
In-Reply-To: <8f346a89044203c38012861a3aa3cf7c63499c96.camel@phytec.de>

Hi,

On 20.06.22 14:47, Teresa Remmet wrote:
> Am Montag, dem 20.06.2022 um 14:38 +0200 schrieb Ahmad Fatoum:
>> On 20.06.22 14:27, Teresa Remmet wrote:
>>> I have set the DDRC_ADDRMAP7 register manually in the RAM
>>> configuration
>>> in such a case. As I don't see a solution that fits for all. But
>>> would
>>> be happy for one. :)
>>
>> What would the 'neutral' value to write into this register be? zero
>> seems to not be it.
> 
> it's 
> 
> 0xf0f for ADDRMAP7.
> 
> Reference Manual says: "If set to 15, row address bit X is set to 0"

Do newer spreadsheets always generate ADDRMAP7 writes even if the
value is zero? If so, we could perhaps initialize it to 0xf0f before
running ddr_cfg_umctl2(). The DDRC seems to be in reset while the
registers are being written, so this might just work.

As 0 is a valid value, I am wondering if this snippet introduced with
42d45ef380c5 ("ARM: imx: Add imx8 support for SDRAM with two or more bank groups")
is correct:

if (addrmap[8]) {
        if (FIELD_GET(DDRC_ADDRMAP8_BG_B0, addrmap[8]) != 0b11111)
                banks++;
        if (FIELD_GET(DDRC_ADDRMAP8_BG_B1, addrmap[8]) != 0b111111)
                banks++;
}

Thanks,
Ahmad

> 
> Regards,
> Teresa
> 
> 
>>
>> Thanks,
>> Ahmad
>>
>>> Regards,
>>> Teresa
>>>
>>>>> ---
>>>>>  arch/arm/mach-imx/esdctl.c | 2 +-
>>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/arch/arm/mach-imx/esdctl.c b/arch/arm/mach-
>>>>> imx/esdctl.c
>>>>> index 8dd0ddbbc965..b070ebc62a45 100644
>>>>> --- a/arch/arm/mach-imx/esdctl.c
>>>>> +++ b/arch/arm/mach-imx/esdctl.c
>>>>> @@ -488,7 +488,7 @@ static resource_size_t
>>>>> imx8m_ddrc_sdram_size(void __iomem *ddrc)
>>>>>  
>>>>>  	return imx_ddrc_sdram_size(ddrc, addrmap,
>>>>>  				   12, ARRAY_AND_SIZE(col_b),
>>>>> -				   16, ARRAY_AND_SIZE(row_b),
>>>>> +				   18, ARRAY_AND_SIZE(row_b),
>>>>>  				   reduced_adress_space, true);
>>>>>  }
>>>>>  
>>
>>


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  reply	other threads:[~2022-06-20 13:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20 14:23 Teresa Remmet
2022-05-24  7:10 ` Sascha Hauer
2022-06-20 12:02 ` Ahmad Fatoum
2022-06-20 12:27   ` Teresa Remmet
2022-06-20 12:38     ` Ahmad Fatoum
2022-06-20 12:47       ` Teresa Remmet
2022-06-20 13:19         ` Ahmad Fatoum [this message]
2022-06-21 12:59           ` Teresa Remmet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8dfb72b-3a12-eef5-13ff-894f60a90159@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=T.Remmet@phytec.de \
    --cc=barebox@lists.infradead.org \
    --cc=joacim.zetterling@westermo.com \
    --cc=lst@pengutronix.de \
    --cc=upstream@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox